[GUI] New <depth> tag for stereoscopic effect for controls. #7855
Conversation
afedchin
added
Type: Feature
|
Thanks, looks simple and clean. @da-anda you're going to adjust Confluence? |
|
yes, will give it a try, even though I have no clue of our skinning engine. Will at least hack around in Confluence to test the effect :) |
|
@afedchin as we have something similar for subtitles and we name it stereoscopic depth e.g. |
|
@xhaggi I think you can see the "depths" value as the location within the available depths range, while "strength" defines the size of the range. So not sure if they should use the same naming. |
|
makes sense :) |
| #empty strings from id 36550 to 36599 | ||
| #: system/settings/settings.xml | ||
| msgctxt "#36550" | ||
| msgid "GUI Stereo Effect Strength" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
works great - thanks. Adjustments to Confluence will take a while and can/should be done independent of this PR. So good to go from my end, once jjd-uk checked the labels |
| @@ -17115,7 +17115,18 @@ msgctxt "#36549" | |||
| msgid "Use iOS8 compatible AirPlay support. If you have trouble with older iOS devices detecting this application as a valid target try switching this off. This option requires a restart to take effect!" | |||
| msgstr "" | |||
|
|
|||
| #empty strings from id 36550 to 36599 | |||
| #: system/settings/settings.xml | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…meter (default 0).
…or stereo corrections.
…ntrol will be "in front" or "in back" in stereo mode.
…will be "in front" or "in back" in stereo mode.
afedchin
force-pushed
the
stereo_controls
branch
from
e7c62f8
to
e000343
Compare
|
rebased and squashed. |
|
jenkins is busy today. if there isn't objection and build will success, @MartijnKaijser please merge this in next window |
|
@jjd-uk reads good, but the puctuation seems odd. I'd go with: |
|
That's fine with me |
afedchin
force-pushed
the
stereo_controls
branch
from
e000343
to
3a3a8fa
Compare
|
jenkins build this please |
[GUI] New <depth> tag for stereoscopic effect for controls.
This added a new tag for control/group/window and defines stereoscopic effect for them. The possible values of tag are [-1.0, 1.0] which bring control "to back" and "to front".
ping @da-anda @mkortstiege @MartijnKaijser
also please someone review the description and name of setting.