[CONTAINERART] Fix Container.Art property for artist directories

[pbureau]

As detailed in this thread:
http://forum.kodi.tv/showthread.php?tid=235413&pid=2087854#pid2087854

I believe there are some issues with the current Container.Art(artist.fanart) property implementation.

The proposed patch adds a new method called in CGUIWindowMusicBase::GetDirectory() to make the property functional for artists directories and fixes the GetAlbumId() return value test

[mkortstiege]

Shouldn't GetArtForItem(params.GetArtistId(), MediaTypeArtist, artistArt) work?

[pbureau]

You are right, it should definitely work.

[pbureau]

ok I pushed a new commit with the suggested change.

[ronie]

could you add some before/after screenshots of wwhat this is supposed to fix?

tbh, i don't quite understand your problem report on the forum.

[pbureau]

Well I am not sure a screen shot will help here. The issue I have is that $INFO[Container.Art(artist.fanart)] will not return anything when looking at an artist path such as musicdb://artists/5

To me, it seems logical this property should return art for the current artist when looking at the artist page. This is the behavior I was expecting.

[mkortstiege]

I've not runtime tested this yet, but the actual changes are looking good to me. Could you please squash the commits to one?

[pbureau]

ok done.

[ronie]

Well I am not sure a screen shot will help here. The issue I have is that $INFO[Container.Art(artist.fanart)] will not return anything when looking at an artist path such as musicdb://artists/5

well, sometimes pictures say more than a thousand words :-)

$INFO[Container.Art(artist.fanart)] is only supposed to work at album and song level,
as it returns the fanart image for the parent container.

on artist level, there's no parent container. well, the root listing of the music library maybe..
you should use $INFO[ListItem.Art(fanart)] there.

[pbureau]

The problem with $INFO[ListItem.Art(fanart)] is that it returns the fanart for the currently selected item, and:

1. Sometimes there is no selected item, then the property returns nothing
2. When an artist view contains albums from different artists (think about featuring), the result changes depending on the item selected

Which means there is no way to consistently display fanart for the current artist in the artist view, which is a shame, and is solved by the proposed patch :-)

[Hitcher]

Use a variable to fallback to Container.Art(artist.fanart) when ListItem.Art(fanart) is empty.

[ronie]

i'd like to request those screenshots again, as i still don't get whether your problems are at artist level (the main list of all artists in your library) or at album level (the list of all albums by a certain artist).

if this PR fixes stuff at album level, then that's accepted for sure.

[pbureau]

Sorry for the delay. Here is a screen shot:

In this view, the background is the fanart corresponding to the current artist (Jay-Z). In this particular situation $INFO[ListItem.Art(fanart)] would return nothing as the up item is selected, and it would return fanart for eminem if the 8 miles item is selected.

[ronie]

great, i remember that issue, it's been around for a long time.
http://trac.kodi.tv/ticket/14290

before we had the container.art() stuff, skinners could use the $INFO[Fanart.Image] infolabel for this purpose, but it broke at one point. that bug was probably carried over to the container.art() implementation.

@mkortstiege ok to merge?

[Hitcher]

Isn't this covered by using a variable as I posted above though?

[phil65]

nope, that wouldnt solve it completely. A container property is correct for this case.

[ronie]

nope, the problem is that Container.Art(artist.fanart) returns empty when you focus the parentdir (..) item.

[Hitcher]

But that's the same for season and episode views, so can we get them fixed as well?

[ronie]

it works fine on my end there.
Container.Art(tvshow.fanart)

[Hitcher]

Of course it does, sorry.

[hudokkow]

jenkins build this please

[mkortstiege]

+1

[ronie]

@pbureau thx!

[phil65]

I think the only Container.Art() missing now is for movie sets. @HitcherUK could you confirm this? Container.Art(fanart) didnt seem to work for me in that case.

[Hitcher]

Has it ever worked for sets?

[phil65]

not yet afaik, but it should be added for consistency.

[mkortstiege]

not yet, but it should be added for consistency.

#7914 takes care of that.

[pbureau]

thx for the merge, it certainly feels like an accomplishment :)

By the way I noticed the second test should actually be an "else if"... I will correct this.