-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vizualization] Fixed Vortex vizualization crash during window resize. #7903
Conversation
… an issue during window resizing. (added SAFE_RELEASE/SAFE_DELETE macros)
jenkins build this please |
do you already have a test build up somewhere? If not I'll ask jenkins later |
just ask jenkins for this |
jenkins build this please |
tested it and Kodi no longer crashes with Vortex. I noticed though that on every window resize the viz is being reset. Also some of the Vortex presets don't seem to work correctly. Looks like they don't get any audio data for processing (amplitudes are just flat lines). But those are different issues, unrelated to this bugfix. |
@Paxxi, @Montellese i guess this one is good to go? Would like to have it in next snapshot. |
A lot of odd / mismatching indentation throughout the changes but looking at the current state it's not much better. |
this is obsolete after #5329 |
@kfarhat - one last time. YOU (!!!!) created a github account and somehow subscribed to the XBMC repository. Because of that github(!!!!!) is sending you instant email notifications about the development that's going on in this repository. If you don't want to be notified by github about stuff that happens in the repositories you subscribed to, then a) either unsubscribe by visiting the github page of according repository and click the "unsubscribe" button in the right column or b) change the notification settings in your github account to your liking. And now STOP spamming us, because every useless comment/reply from you to the github notifications is spamming tons of devs that actually do care for these notifications, but only development related notifications and not your inability to disable mail notifications of github. |
see title
@da-anda please check this.