Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vizualization] Fixed Vortex vizualization crash during window resize. #7903

Closed
wants to merge 2 commits into from

Conversation

afedchin
Copy link
Member

see title

@da-anda please check this.

Anton Fedchin added 2 commits August 27, 2015 01:54
@afedchin
Copy link
Member Author

jenkins build this please

@da-anda
Copy link
Member

da-anda commented Aug 28, 2015

do you already have a test build up somewhere? If not I'll ask jenkins later

@afedchin
Copy link
Member Author

just ask jenkins for this

@afedchin afedchin added Type: Fix non-breaking change which fixes an issue v16 Jarvis labels Aug 28, 2015
@afedchin
Copy link
Member Author

jenkins build this please

@da-anda
Copy link
Member

da-anda commented Aug 29, 2015

tested it and Kodi no longer crashes with Vortex. I noticed though that on every window resize the viz is being reset. Also some of the Vortex presets don't seem to work correctly. Looks like they don't get any audio data for processing (amplitudes are just flat lines). But those are different issues, unrelated to this bugfix.

@mkortstiege
Copy link
Member

@Paxxi, @Montellese i guess this one is good to go? Would like to have it in next snapshot.

@Montellese
Copy link
Member

A lot of odd / mismatching indentation throughout the changes but looking at the current state it's not much better.

@afedchin
Copy link
Member Author

this is obsolete after #5329

@afedchin afedchin closed this Sep 14, 2015
@afedchin afedchin deleted the fix_vortex branch September 14, 2015 07:34
@da-anda
Copy link
Member

da-anda commented Sep 14, 2015

@kfarhat - one last time. YOU (!!!!) created a github account and somehow subscribed to the XBMC repository. Because of that github(!!!!!) is sending you instant email notifications about the development that's going on in this repository. If you don't want to be notified by github about stuff that happens in the repositories you subscribed to, then a) either unsubscribe by visiting the github page of according repository and click the "unsubscribe" button in the right column or b) change the notification settings in your github account to your liking. And now STOP spamming us, because every useless comment/reply from you to the github notifications is spamming tons of devs that actually do care for these notifications, but only development related notifications and not your inability to disable mail notifications of github.
As this is your github account only YOU can disable these notifications, we can't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants