[video] add listitem audio/subtitle properties from streamdetails #7921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkortstiege
added
Type: Feature
| CStreamDetails& details = item.GetVideoInfoTag()->m_streamDetails; | ||
|
|
||
| // add audio language properties | ||
| for (int i = 1; i <= details.GetAudioStreamCount(); i++) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
cool! +1 |
|
yup, very nice. Thx! |
mkortstiege
added a commit
that referenced
this pull request
Sep 1, 2015
[video] add listitem audio/subtitle properties from streamdetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a in-core replacement for
script.videolanguage. Since we already know about the streamdetails there's no need to perform additional json look-ups just to fill those.If available, the following audio and subtitle based properties will be filled from streamdetails:
Unlike the script this is setting the properties on the actual
ListItem. Skins just need to replaceWindow.PropertywithListItem.Property. After that the script dependency can be ditched./cc @BigNoid, @HitcherUK, @Montellese, @phil65, @ronie, @vonH