[builtins] adds ToggleRegionVisualization builtin

[mkortstiege]

Adds new ToggleDirtyRegions builtin. This enables on-the-fly dirty-region visualization toggling without the need to restart Kodi.

Requested by @HitcherUK.

[Hitcher]

Thanks.

[mkortstiege]

@Montellese objections?

[mkortstiege]

Will shove this in later today if there are no objections.

[Montellese]

Could you rename the builtin to make it clear that it toggles the visualization? ToggleDirtyRegions sounds to me like it switches between two different modes of dirty regions (even though there are at least three).

[mkortstiege]

Sure. What about ToggleDirtyRegionVisualization or just ToggleDRVisualization? A bit long maybe ..

EDIT: ToggleRegionVisualization would work for me as well ;)

[mkortstiege]

Made it ToggleRegionVisualization now.

[Montellese]

I'd go with ToggleDirtyRegionVisualization as it explains best what it does. ToggleRegionVisualization is not that obvious by itself without any documentation.

[topfs2]

Im guessing that the original advanced settings is because not all visualisations understand dirty regions? Kind of outside this PR but wouldn't it be better if they simply flagged their support in the add-on.XML, removing the need for this?

[mkortstiege]

@Montellese. Will do.
@topfs2 it's not about visualizations ;) This is is to toggle dirty region visualization on/off without the need to restart Kodi.

[topfs2]

Oh wait. Is this the debug were it displays them on screen?

[topfs2]

Do we name debug stuff like this in any consistent matter. Would be nice if you instantly knew it is debug related. Perhaps something like DebugShowDirtyRegions

[mkortstiege]

Updated. Builtin now uses ToggleDirtyRegionVisualization. I've also added a keyboard keymap commit that enables this via ctrl+shift+r (analogue to ToggleDebug).

@topfs2, I'd like to keep the term Toggle in there without making it longer.

[Montellese]

jenkins build and merge

[topfs2]

@mkortstiege yeah probably good with toggle naming tbh