Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confluence] Show user rating in info #7955

Closed
wants to merge 2 commits into from

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Sep 3, 2015

Shows the user rating in the DIalogVideoInfo list.
@ronie

Also a small cleanup for an obsolete declaration

@mkortstiege
Copy link
Member

I've not runtime tested this, but won't adding the user rating label lead to a scrolling in the info area?

@razzeee
Copy link
Member Author

razzeee commented Sep 4, 2015

That's probably dependent on your display and how much data the scraper can gather. The one that seems at the limit is movies.

screenshot 2015-09-04 14 37 53
screenshot 2015-09-04 14 40 00

@mkortstiege
Copy link
Member

Found a scenario where at least one existing item falls out of the actual info area.

screenshot001

I had to switch to preferred language de in order to get the original title. Looks like we need to re-layout the info dialog if we want to show user ratings as path is on next page and there's not scroll indicator.

@Montellese
Copy link
Member

Why don't we combine it with the Rating row?

@razzeee
Copy link
Member Author

razzeee commented Sep 4, 2015

I like @Montellese idea, but I don't know how we can make clear which is which.

@phil65
Copy link
Contributor

phil65 commented Sep 4, 2015

If we show the user rating, then we should also add a button to set that rating. The user rating label could perhaps get moved to the button control label in that case

@razzeee
Copy link
Member Author

razzeee commented Sep 4, 2015

Yes, but as of now the video db info is just a list. And from my limited skinning skills I would assume, that you can't have buttons in a list?
The music db info screen is done without a list and seems like the items are placed by hand.

@phil65
Copy link
Contributor

phil65 commented Sep 4, 2015

atm the info part is a list container, and you can also assign < onclick > actions to the items.
My idea was to move "set rating" to the horizontal menu (grouplist) though.

@razzeee
Copy link
Member Author

razzeee commented Sep 4, 2015

So should I edit this to be just the cleanup?

@phil65
Copy link
Contributor

phil65 commented Sep 4, 2015

I´d say let´s wait for @ronie or someone else with an opinion on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants