[addons] move rollback feature to the update dialog #8167
Conversation
tamland
added
Type: Fix
tamland
force-pushed
the
rollback_rework
branch
2 times, most recently
from
4eafebb
to
0bac8d6
Compare
|
jenkins build this please |
|
Could you change the dialog to highlight only the currently used one? btw, do we want the users to be able to replace currently used with currently used? Other than that i really like it ;) |
|
@mkortstiege As we don't track the origin there is no way to know which is the currently used one, only the version. I agree it's a bit weird to highlight all versions, but that's what can be done currently. |
|
OK. |
| @@ -259,6 +259,8 @@ bool CAddonInstaller::InstallFromZip(const std::string &path) | |||
| if (!g_passwordManager.CheckMenuLock(WINDOW_ADDON_BROWSER)) | |||
| return false; | |||
|
|
|||
| CLog::Log(LOGDEBUG, "CAddonInstaller: installing from zip '%s'", path.c_str()); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…alog similar behaviour to the other actions
tamland
force-pushed
the
rollback_rework
branch
from
0bac8d6
to
bc36b26
Compare
|
good to go then? |
|
Jep, merge away once build successfully. |
[addons] move rollback feature to the update dialog
|
@tamland can we display a '..' item in the select dialog if no versions are available? empty lists in kodi are evil and break navigation.
|
|
Or "none available" or something |
|
I think in that case the SelectDialog shouldnt even open, just a notification with "none available" would be enough. |
|
...or perhaps even disabling that button. |
|
Disable that button in that case should be preferred |
|
I dislike disabling it as it would make the info dialog lag again. it's an architectural problem. Now, the delay is at least contained to the update dialog. |
|
This is really weird btw. Why would an empty list outright break navigation? if that's the case we probably have a lot more broken dialogs. |
|
we prevented broken navigation by always adding an item iirc |
we can't focus a list if it contains no listitems. skins have to define the id of the control that should be focused when a window/dialog opens. if the list is empty, kodi can't focus it. as a result no control will be focused. |
|
Then the correct solution is to focus the close button. Possible to fix in skin? |
|
nope. |
This fixes and unifies the rollback and update feature by listing all available version (local packages or remote) in one place, in the update dialog.