[depends] update cmake to 3.3.2 #8183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
I think we should bump to >= cmake 3.2 as 2.x is getting really dated. |
|
yes, bite the bullet now and not later. very little will break, iirc all it took was adding a policy to quell some noise. |
AlwinEsch
force-pushed
the
depends-native-cmake
branch
2 times, most recently
from
7ef5674
to
0467f8d
Compare
AlwinEsch
changed the title
|
Is updated and use now the latest Version 3.3.2 of CMake, the test build here was complete OK for Kodi and add-on's |
AlwinEsch
force-pushed
the
depends-native-cmake
branch
from
0467f8d
to
7ca01a2
Compare
AlwinEsch
force-pushed
the
depends-native-cmake
branch
from
7ca01a2
to
6f33c5a
Compare
|
great thanks, I'll upload the tar to our mirrors now. jenkins build this please |
AlwinEsch
force-pushed
the
depends-native-cmake
branch
from
6f33c5a
to
d5f87e9
Compare
|
Thank you return, file now visible on the mirror and my temporary patch removed. jenkins build this please again a last time. |
|
As note about the view of last broken build messages from jenkins on linux I created this Request xbmc/screensaver.matrixtrails#4. |
AlwinEsch
added a commit
that referenced
this pull request
Oct 6, 2015
[depends] update cmake to 3.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request contains a for Chromium CEF needed update which require the final version 2.8.12.2 of cmake in 2. series.
EDIT: This request change to use the newest CMake version for depends.
The second patch contains a temporary change to use URL from CMake direct for test build (https://cmake.org/files/v3.3/cmake-3.3.2.tar.gz). If it is ok then need this be added to Kodi's web storage.
The newest Version of CMake is 3.3.2, I think to compatibility with older system versions is better to stay in 2. What do you think?