Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confluence] Add 'Events' to Home screen's 'System' submenu. #8222

Merged
merged 1 commit into from Oct 15, 2015

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 14, 2015

As discussed at DevCon, this adds an entry 'Events' to Confluence home screen, 'System' submenu. The new entry is only visible, if "Settings->System->Logging->Enable event logging" is checked. When the new entry gets selected, the event log window opens, like if started directly from "Settings->System->Logging->Show event log"

screenshot003

@ronie, @Montellese mind taking a look.

@ksooo ksooo added Type: Feature non-breaking change which adds functionality v16 Jarvis labels Oct 14, 2015
@ksooo ksooo added this to the Jarvis 16.0-alpha4 milestone Oct 14, 2015
@ronie
Copy link
Member

ronie commented Oct 14, 2015

nice, no objections from my end.

@phil65
Copy link
Contributor

phil65 commented Oct 14, 2015

yup nice, although I only can remember a discussion to put Eventlog into "System information" window? But perhaps that's related to my constant hangover there. :)

@ksooo
Copy link
Member Author

ksooo commented Oct 14, 2015

System information windows does imo not really make sense, because the windows there are all "passive" - no selectable content, just non-interactive read-only stuff there. Event log window is different - interactive, you can do "things" with the event log entries.

@phil65
Copy link
Contributor

phil65 commented Oct 14, 2015

True, but it still makes much more sense than to put it into settings imo ;).
anyways, not related at all to this PR. I'd say press the green button, @ronie

@Montellese
Copy link
Member

Already forgot about this so thanks for remembering and getting it done.

@razzeee
Copy link
Member

razzeee commented Oct 15, 2015

Is there no potential harm in changing the id of the old entry?

MartijnKaijser added a commit that referenced this pull request Oct 15, 2015
[Confluence] Add 'Events' to Home screen's 'System' submenu.
@MartijnKaijser MartijnKaijser merged commit 5b8380e into xbmc:master Oct 15, 2015
@ronie
Copy link
Member

ronie commented Oct 15, 2015

nope, it's not a problem here. it's only an issue when:

  • it's built-in id
  • the id is evaluated elsewhere in the skin to conditionally display stuff
  • two visible controls in the same window would now have the same id

@razzeee
Copy link
Member

razzeee commented Oct 15, 2015

Thanks.
Figured it might cause problems when the ID might also be used in the C++ code. It's not the case here, but to be safe 100% I thought it might be nicer, to not change ids of old elements.

@ksooo ksooo deleted the confluence-homescreen-eventlog branch October 15, 2015 08:27
stefansaraev added a commit to stefansaraev/xbmc that referenced this pull request Oct 15, 2015
stefansaraev added a commit to stefansaraev/xbmc that referenced this pull request Oct 15, 2015
ksooo added a commit that referenced this pull request Oct 15, 2015
[Confluence] on left/right fixup after #8222
stevegal pushed a commit to stevegal/xbmc that referenced this pull request Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature non-breaking change which adds functionality v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants