Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] add ability to visualize control hitrects #8230

Merged
merged 1 commit into from Oct 16, 2015

Conversation

mkortstiege
Copy link
Member

This adds the ability to visualize hitrects for controls. When visible and there's a tag, it will paint a colored rectangle over the actual control. Colors can be specified in AARRGGBB format or with a name from the color theme.

Example: <hitrectcolor>4033FF99</hitrectcolor> added to a scrollbar control ..

screenshot000

/cc @BigNoid, @HitcherUK, @phil65, @ronie, @vonH

This adds the ability to visualize hitrects for controls. When visible and there's a
<hitrectcolor> tag, it will paint a colored rectangle over the actual control. Colors
can be specified in AARRGGBB format or a name from the color theme.
@mkortstiege mkortstiege added the Type: Improvement non-breaking change which improves existing functionality label Oct 15, 2015
@BigNoid
Copy link
Member

BigNoid commented Oct 15, 2015

As mentioned on slack, this works and looks good for me.

@ronie
Copy link
Member

ronie commented Oct 15, 2015

^ what he said.

@razzeee razzeee added this to the Jarvis 16.0-alpha4 milestone Oct 15, 2015
mkortstiege added a commit that referenced this pull request Oct 16, 2015
[guilib] add ability to visualize control hitrects
@mkortstiege mkortstiege merged commit 15b94e6 into xbmc:master Oct 16, 2015
@mkortstiege mkortstiege deleted the visualize-hitrect branch October 16, 2015 10:04
@MediaBrasil
Copy link

@@ -185,7 +186,15 @@ void CGUIControl::DoRender()
g_graphicsContext.SetStereoFactor(m_stereo);

GUIPROFILER_RENDER_BEGIN(this);

if (m_hitColor != 0xFFFFFFFF)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants