[PVR] activate PVR windows only if PVR is enabled

[ksooo]

If PVR is disabled, prevent activation of PVR windows using shortcut keys (e.g. ctrl+o for "Recordings" window). Simply ignore the key mapping in this case.

Today, if PVR is disabled in settings, an empty window with a dialog "PVR is not yet started up... waiting..." pops up. This dialog must be cancelled then manually by the user.

Not sure whether it is a good approach to put the logic into builtins, though feedback is very welcome @xhaggi, ...

@MartijnKaijser this is the fix we talked about at DevCon.

[xhaggi]

makes totally sense

[mkortstiege]

@ksooo, @xhaggi wouldn't make more sense to move IsPVRWindow() to the actual WindowManager? +1 other than that.

[ksooo]

Yeah, doing the check in CGUIWindowManager::ActivateWindow_Internal is IMHO better. Any objections to change it that way?

[xhaggi]

sure, makes sense too 😄

[Montellese]

Doing it in CGUIWindowManager will cover all cases and not just builtins but it doesn't feel quite right there either as the window manager should be agnostic to the state and settings of PVR.

[ksooo]

@Montellese that's exactly why I did not put it there initially. So, any ideas?

Stick with the initial approach or head for something different?

Maybe a new virtual member function like bool CGUIWindow::CanBeActivated() that would be used by CGUIWindowManager::ActivateWindow_Internal and overridden by the PVR windows?

[xhaggi]

makes sense IMO

[Jalle19]

@ksooo that sounds like a good idea

[zag2me]

No brainer this one, it always bugged me when I accidently hit a pvr button on the remote before I had this installed.

[da-anda]

I was also thinking about some way to hook into the process and interfere the action. So basically firing some event/message/signal and when some listener sets some flag (like "preventDefaultAction", "process = false", ...) then the sender ignores doing anyting. A little like JavaScript events. Might be a bit over the top for this particular case, but I think we should in general use more signals/messages for other parts to hook in and decouple stuff.

[ksooo]

Now I implemented the CGUIWindow::CanBeActivated approach. What do the devs think? @xhaggi @negge @Montellese @mkortstiege

[Jalle19]

👍

[mkortstiege]

Jep, looks much cleaner now. Thanks.

[xhaggi]

+1 this could perfectly fits also to other scenarios where we want to block window activation

[Jalle19]

jenkins build this please