[filesystem] add videodb://inprogresstvshows #8261

InuSasha · 2015-10-19T16:11:01Z

add the videodb://inprogresstvshows to the filesystem-tree.

@un1versal: after merge you may make a second try on #4469

un1versal · 2015-10-19T16:25:23Z

Thanks!! this is fantastic, will test asap.

related forum request thread http://forum.kodi.tv/showthread.php?tid=233374

@un1versal: after merge you may make a second try on #4469

What do you mean?

This will need skin implementation like in #4469 no?

ronie · 2015-10-19T18:40:05Z

+1 from my end

never understood there's a videodb:// path for everything except inprogress tv shows

xbmc/filesystem/VideoDatabaseDirectory/DirectoryNodeInProgressTvShows.cpp

@@ -0,0 +1,56 @@
+/*
+ *      Copyright (C) 2005-2013 Team XBMC


InuSasha · 2015-10-19T19:22:25Z

@razzeee done, but i have found 66 different kinds of this header!!!!

xbmc/filesystem/VideoDatabaseDirectory/DirectoryNodeInProgressTvShows.h

+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with XBMC; see the file COPYING.  If not, see


InuSasha · 2015-10-19T22:33:07Z

@razzeee changed, too

Implement xbmc#8261 in TVSHOWS submenu

InuSasha · 2015-10-20T12:34:10Z

added the json-rpc method

MartijnKaijser · 2015-10-20T12:39:16Z

Needs jsonrpc version bump. @Montellese ping

InuSasha · 2015-10-20T12:44:43Z

have something todo for the version bump?

hudokkow · 2015-10-20T12:56:20Z

See https://github.com/xbmc/xbmc/pull/7788/commits for an example of jsonrpc bump

un1versal · 2015-10-20T13:11:31Z

Bump https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/schema/version.txt to 6.31.0 I think

InuSasha · 2015-10-20T13:30:30Z

bumped to 6.30.1

un1versal · 2015-10-20T13:33:08Z

bumped to 6.30.1

I always thought minor version bumps are bug fixes and the others features like hudo done hudokkow@138f720

hudokkow · 2015-10-20T14:48:28Z

Thanks @un1versal
@InuSasha, please bump to 6.31.0. Sorry for not being more specific.

xbmc/interfaces/json-rpc/JSONServiceDescription.cpp

@@ -134,6 +134,7 @@ JsonRpcMethodMap CJSONServiceDescription::m_methodMaps[] = {
  { "VideoLibrary.GetRecentlyAddedMovies",          CVideoLibrary::GetRecentlyAddedMovies },
  { "VideoLibrary.GetRecentlyAddedEpisodes",        CVideoLibrary::GetRecentlyAddedEpisodes },
  { "VideoLibrary.GetRecentlyAddedMusicVideos",     CVideoLibrary::GetRecentlyAddedMusicVideos },
+  { "VideoLibrary.GetInProgressTvShows",            CVideoLibrary::GetInProgressTvShows },


Montellese · 2015-10-20T17:22:38Z

Not a huge fan of introducing yet another hardcoded videodb://foo URL as we have been trying to get rid of them by introducing the library nodes feature. But I know that the library nodes aren't perfect yet either and not fully reliable for usage in skins etc.

MartijnKaijser · 2015-10-20T17:34:57Z

@Montellese since it's too late anyways to get this in v16 maybe some suggestion on how to proceed?

InuSasha · 2015-10-20T17:39:00Z

bump to 6.31.0.
And rename TvShow to TVShow. But the camell-case of TVShow is different between JSON (TVShow) and rest (TvShow).

razzeee · 2015-10-21T08:05:51Z

Just a comment and I know that the other vfs are also like this one, but I think it would make much more sense to go after something likevideodb://tvshows/inprogress in the long run.

InuSasha · 2015-10-21T08:41:57Z

great idea! when the other agree, i will change it.

Montellese · 2015-10-21T08:44:19Z

Please keep it in line with the existing naming schema for now. IMO there shouldn't be any of these shortcuts as they can all be achieved using videodb://tvshows/?xsp={....} with the proper JSON representation of a smartplaylist in JSON doing the proper filtering.

un1versal · 2015-10-21T09:01:56Z

Ive tested this and works 100% ontop of master.

@Montellese since it's too late anyways to get this in v16 maybe some suggestion on how to proceed?

:( thats really a shame and bad news with this in - #8279 is also a possibility and is up to help more testing to happen even if a few users have already tested and report this working.

Implement xbmc#8261 in TVSHOWS submenu

xbmc/interfaces/json-rpc/schema/version.txt

@@ -1 +1 @@
-6.30.0
+6.31.0


anaconda · 2016-01-09T17:32:20Z

jenkins build this please

razzeee · 2016-01-09T21:21:02Z

Btw does this recommend specials or are they excluded?

InuSasha · 2016-01-09T21:24:50Z

what do mean exactly?

razzeee · 2016-01-10T02:42:49Z

@InuSasha
Never mind, I just compiled it myself and checked. Everything is fine.

InuSasha · 2016-01-10T11:41:45Z

@anaconda updated the license header (to 2016 and kodi). do not change license header in untouched files (like requested)

razzeee · 2016-01-10T13:42:47Z

Let's build this one more time

jenkins build this please

razzeee · 2016-01-10T16:03:44Z

Please rebase one more time, I'll merge this then.
Sorry for the conflicts :(

visualstudio by Razzeee xcode by anaconda

…ows to json-rpc

InuSasha · 2016-01-10T16:18:35Z

done, with no change

razzeee · 2016-01-10T18:13:41Z

jenkins build and merge

…s_node

[confluence] add "In progress" submenu entry to TV SHOWS - Depends on #8261

razzeee · 2016-03-09T22:13:49Z

As a headsup, @InuSasha
I will do a cleanup here, as the name "in progress" is misleading or wrongly used. On movies, it referes to movies you started and not finished. What we're doing here will need another name, to keep it clear.

InuSasha · 2016-03-09T22:22:26Z

do you really mean is misleading?
It refers to started but not finished tvshows (view some not all episodes).
But the wording is not important for me. Actual, i do not know a better wording.

razzeee · 2016-03-09T22:28:59Z

I think it's misleading, as we can already filter episodes/movies by in progress. But that's a different thing.

Movies "In progress" are stuff you haven't finished watching.

TV Show "In progress" is what's next to watch...

razzeee · 2016-03-09T22:30:53Z

So if we add the same row that movies has for episodes, it becomes weird ;)

Montellese · 2016-03-09T22:31:43Z

Personally I don't find it misleading. It's not called "In progress episodes" which would/should be identicall to "In progress movies". A tv show is a container and it's in progress if any of its children has been watched and the progress is the latest/newest child that has been watched.

ronie · 2016-03-09T22:34:12Z

i'm not really seeing a problem with it either...

razzeee · 2016-03-09T22:35:56Z

@Montellese
I believe that's a very technical way of thinking about it. Not sure if users would get that/think about that in that way from the start.
http://forum.kodi.tv/showthread.php?tid=263585&pid=2275356#pid2275356
But that would mean we can leave it as it is in core.

InuSasha · 2016-03-09T22:44:24Z

@razzeee
you mean something like "next episode on in progress tvshows".
have you a proposal?

Hitcher · 2016-03-10T00:36:24Z

Many skins have used 'In Progress TV Shows' for some years now.

MartijnKaijser · 2016-03-10T08:11:13Z

@razzeee if we would follow the genera users opinion or reasoning this program would be totally FUBAR. There's nothing wrong with in progress tvshow

razzeee · 2016-03-10T08:16:26Z

Well then ignore me :)
Sorry for the noise

razzeee reviewed Oct 19, 2015
View reviewed changes

xbmc/filesystem/VideoDatabaseDirectory/DirectoryNodeInProgressTvShows.cpp

@@ -0,0 +1,56 @@

/*

* Copyright (C) 2005-2013 Team XBMC

This comment was marked as spam.

Sign in to view

razzeee reviewed Oct 19, 2015
View reviewed changes

xbmc/filesystem/VideoDatabaseDirectory/DirectoryNodeInProgressTvShows.h

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with XBMC; see the file COPYING. If not, see

This comment was marked as spam.

Sign in to view

un1versal added a commit to un1versal/kodi that referenced this pull request Oct 20, 2015

[confluence] Add In Progress submenu entry to TVSHOWS

162a027

Implement xbmc#8261 in TVSHOWS submenu

Montellese reviewed Oct 20, 2015
View reviewed changes

un1versal added a commit to un1versal/kodi that referenced this pull request Oct 23, 2015

[confluence] Add In Progress submenu entry to TVSHOWS

058ec7f

Implement xbmc#8261 in TVSHOWS submenu

un1versal mentioned this pull request Oct 23, 2015

[confluence] add "In progress" submenu entry to TV SHOWS - Depends on #8261 #8279

Merged

razzeee added the v17 Krypton label Oct 23, 2015

MartijnKaijser mentioned this pull request Oct 25, 2015

[confluence] add support for widgets #8296

Closed

un1versal added a commit to un1versal/kodi that referenced this pull request Nov 27, 2015

[confluence] Add In Progress submenu entry to TVSHOWS

1a5b2f4

Implement xbmc#8261 in TVSHOWS submenu

un1versal reviewed Dec 6, 2015
View reviewed changes

xbmc/interfaces/json-rpc/schema/version.txt

@@ -1 +1 @@

6.30.0

6.31.0

This comment was marked as spam.

Sign in to view

razzeee added API change: JSON-RPC Component: Video labels Jan 10, 2016

InuSasha added 2 commits January 10, 2016 17:17

[filesystem] add videodb://inprogresstvshows

1f7f3af

visualstudio by Razzeee xcode by anaconda

[json] add videodb://inprogresstvshows as VideoLibrary.InProgressTvSh…

669803e

…ows to json-rpc

jenkins4kodi added a commit that referenced this pull request Jan 10, 2016

Merge pull request #8261 from InuSasha/feature/master/inprogesstvshow…

e0744f0

…s_node

jenkins4kodi merged commit e0744f0 into xbmc:master Jan 10, 2016

InuSasha deleted the feature/master/inprogesstvshows_node branch January 10, 2016 19:21

ronie added a commit that referenced this pull request Jan 10, 2016

Merge pull request #8279 from un1versal/A-Man-for-All-Seasons

5259c91

[confluence] add "In progress" submenu entry to TV SHOWS - Depends on #8261

razzeee added a commit that referenced this pull request Jan 10, 2016

Fix typo in #8261

7bd1afb

ronie added a commit that referenced this pull request Jan 11, 2016

fix another typo #8261

9f06f86

[filesystem] add videodb://inprogresstvshows #8261

[filesystem] add videodb://inprogresstvshows #8261

Conversation

InuSasha commented Oct 19, 2015

un1versal commented Oct 19, 2015

ronie commented Oct 19, 2015

This comment was marked as spam.

InuSasha commented Oct 19, 2015

This comment was marked as spam.

InuSasha commented Oct 19, 2015

InuSasha commented Oct 20, 2015

MartijnKaijser commented Oct 20, 2015

InuSasha commented Oct 20, 2015

hudokkow commented Oct 20, 2015

un1versal commented Oct 20, 2015

InuSasha commented Oct 20, 2015

un1versal commented Oct 20, 2015

hudokkow commented Oct 20, 2015

This comment was marked as spam.

Montellese commented Oct 20, 2015

MartijnKaijser commented Oct 20, 2015

InuSasha commented Oct 20, 2015

razzeee commented Oct 21, 2015

InuSasha commented Oct 21, 2015

Montellese commented Oct 21, 2015

un1versal commented Oct 21, 2015

This comment was marked as spam.

anaconda commented Jan 9, 2016

razzeee commented Jan 9, 2016

InuSasha commented Jan 9, 2016

razzeee commented Jan 10, 2016

InuSasha commented Jan 10, 2016

razzeee commented Jan 10, 2016

razzeee commented Jan 10, 2016

InuSasha commented Jan 10, 2016

razzeee commented Jan 10, 2016

razzeee commented Mar 9, 2016

InuSasha commented Mar 9, 2016

razzeee commented Mar 9, 2016

razzeee commented Mar 9, 2016

Montellese commented Mar 9, 2016

ronie commented Mar 9, 2016

razzeee commented Mar 9, 2016

InuSasha commented Mar 9, 2016

Hitcher commented Mar 10, 2016

MartijnKaijser commented Mar 10, 2016

razzeee commented Mar 10, 2016