Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib/pictures] Add an ffmpeg based image loader #8370

Merged
merged 3 commits into from Dec 11, 2015

Conversation

ace20022
Copy link
Member

@ace20022 ace20022 commented Nov 9, 2015

Rewrite of #8214

@ace20022 ace20022 added Type: Feature non-breaking change which adds functionality v16 Jarvis Component: GUI engine labels Nov 9, 2015
@ace20022
Copy link
Member Author

ace20022 commented Nov 9, 2015

@fritsch Could you please have a close look at it, I can't see anything any more ;)

@fritsch
Copy link
Member

fritsch commented Nov 9, 2015

jenkins build this please

@ace20022
Copy link
Member Author

ace20022 commented Nov 9, 2015

If this loader is faster than the cximage one we could make it the default one or even drop cximage.

@ace20022
Copy link
Member Author

ace20022 commented Nov 9, 2015

@fritsch I've rewrote seeking, could you please re-check it?

jenkins build this please

@MartijnKaijser MartijnKaijser modified the milestone: K***** 17.0-alpha1 Dec 4, 2015
…mpeg loader

uses a scaler in its Decode() method and might change width or height.
@ace20022
Copy link
Member Author

@fritsch I've added a comment, good to go? And thx much for the review!

jenkins build this please

@fritsch
Copy link
Member

fritsch commented Dec 11, 2015

@ace20022 yes, fine with me. Thanks much for doing that.

Next: we replace all other Image handling that now can be done with this new code? :-)

@ace20022
Copy link
Member Author

Next: we replace all other Image handling that now can be done with this new code? :-)

I also considered this, but we need intensive performance tests before that step.

ace20022 added a commit that referenced this pull request Dec 11, 2015
[guilib/pictures] Add an ffmpeg based image loader and add WebP support
@ace20022 ace20022 merged commit 182d5bc into xbmc:master Dec 11, 2015
@ace20022 ace20022 deleted the webp2 branch December 11, 2015 10:46
@fritsch
Copy link
Member

fritsch commented Dec 11, 2015

How about a blind test - we just do it and see what happens :-)?

@ace20022
Copy link
Member Author

Okay, but then double-blind ;-)

@stefansaraev
Copy link
Contributor

after quick test with CFFmpegImage forced for everything but gif - confluence is fully functional, and png, jpeg, tiff and bmp images work for me(tm). cximage can go ?

🏃

@ace20022
Copy link
Member Author

I've checked that too during development, but it felt slower sometimes, especially for jpgs. Large png felt faster, so maybe we should/could indeed switch the default loader, but don't rip out cximage for a moth or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Feature non-breaking change which adds functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants