New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[guilib/pictures] Add an ffmpeg based image loader #8370
Conversation
@fritsch Could you please have a close look at it, I can't see anything any more ;) |
jenkins build this please |
If this loader is faster than the cximage one we could make it the default one or even drop cximage. |
@fritsch I've rewrote seeking, could you please re-check it? jenkins build this please |
Based on notspiff's poc.
…mpeg loader uses a scaler in its Decode() method and might change width or height.
@fritsch I've added a comment, good to go? And thx much for the review! jenkins build this please |
@ace20022 yes, fine with me. Thanks much for doing that. Next: we replace all other Image handling that now can be done with this new code? :-) |
I also considered this, but we need intensive performance tests before that step. |
[guilib/pictures] Add an ffmpeg based image loader and add WebP support
How about a blind test - we just do it and see what happens :-)? |
Okay, but then double-blind ;-) |
after quick test with CFFmpegImage forced for everything but gif - confluence is fully functional, and png, jpeg, tiff and bmp images work for me(tm). cximage can go ? 🏃 |
I've checked that too during development, but it felt slower sometimes, especially for jpgs. Large png felt faster, so maybe we should/could indeed switch the default loader, but don't rip out cximage for a moth or so. |
Rewrite of #8214