Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update guilib api to 5.10.0 #8494

Merged
merged 1 commit into from Dec 6, 2015
Merged

update guilib api to 5.10.0 #8494

merged 1 commit into from Dec 6, 2015

Conversation

ronie
Copy link
Member

@ronie ronie commented Dec 6, 2015

xbmc.gui api is at 5.10.0, looks like we forgot to update it here as well.

@ronie ronie added Type: Fix non-breaking change which fixes an issue v16 Jarvis API change: GUI labels Dec 6, 2015
@MartijnKaijser
Copy link
Member

pfff

@MartijnKaijser MartijnKaijser added this to the Jarvis 16.0-beta4 milestone Dec 6, 2015
MartijnKaijser added a commit that referenced this pull request Dec 6, 2015
update guilib api to 5.10.0
@MartijnKaijser MartijnKaijser merged commit f4d3302 into xbmc:Jarvis Dec 6, 2015
@MartijnKaijser
Copy link
Member

@hudokkow could you check if any of the PVR addons needs a bump as well now?

@hudokkow
Copy link
Member

hudokkow commented Dec 6, 2015

Will do.

@FernetMenta
Copy link
Contributor

what is this? I am not aware of a change in addongui

@MartijnKaijser
Copy link
Member

1ec1956

@FernetMenta
Copy link
Contributor

that is xbmc.gui which is different from kodi.guilib
that latter has zero in common with skins

@MartijnKaijser
Copy link
Member

right. still makes it confusing as hell. Guess it needs a revert then

@FernetMenta
Copy link
Contributor

you should remember. I split this and renamed it to be not confusing anymore.

@MartijnKaijser
Copy link
Member

Apparently it still is and i forgot. Additionally some PVR addons also ship custom XML skins which should follow the normal skinning version

@FernetMenta
Copy link
Contributor

Additionally some PVR addons also ship custom XML skins which should follow the normal skinning version

right. so every xbmc.gui bump requires a kodi.guilib bump but the version can be different.

@MartijnKaijser
Copy link
Member

not exactly. xbmc.gui is about the XML files while kodi.guilib is about the available controls. It's unlikely that a xbmc.gui could break the PVR xml files but it could be possible (at least it happened in the past)

@hudokkow
Copy link
Member

hudokkow commented Dec 6, 2015

That's confusing to say the least. See kodi-pvr/pvr.mythtv@2fe2aa7

@FernetMenta
Copy link
Contributor

then all fine with this change if we are not pick about the exact version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: GUI Type: Fix non-breaking change which fixes an issue v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants