New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update guilib api to 5.10.0 #8494
Conversation
pfff |
update guilib api to 5.10.0
@hudokkow could you check if any of the PVR addons needs a bump as well now? |
Will do. |
what is this? I am not aware of a change in addongui |
that is xbmc.gui which is different from kodi.guilib |
right. still makes it confusing as hell. Guess it needs a revert then |
you should remember. I split this and renamed it to be not confusing anymore. |
Apparently it still is and i forgot. Additionally some PVR addons also ship custom XML skins which should follow the normal skinning version |
right. so every xbmc.gui bump requires a kodi.guilib bump but the version can be different. |
not exactly. xbmc.gui is about the XML files while kodi.guilib is about the available controls. It's unlikely that a xbmc.gui could break the PVR xml files but it could be possible (at least it happened in the past) |
That's confusing to say the least. See kodi-pvr/pvr.mythtv@2fe2aa7 |
then all fine with this change if we are not pick about the exact version :) |
xbmc.gui api is at 5.10.0, looks like we forgot to update it here as well.