Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confluence][fix] get rid of view (ID: 51) in pvr channel window which cause issues with viewtypes #8718

Merged
merged 1 commit into from
Jan 1, 2016

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Dec 30, 2015

#6174 introduced a new list view type (ID: 51) which does not work properly and in my opinion is 100% identical with the default list view type (ID: 50). This view type leads to an empty list after #8678 was merged (see #8678 (comment))

@AlwinEsch I can't test it because of missing RDS on my TV channels, could you please provide some screenshots/explanation of what you want to achieve with your changes to the PVR channel window?

@xhaggi xhaggi added Type: Fix non-breaking change which fixes an issue Backport: Needed labels Dec 30, 2015
@xhaggi
Copy link
Member Author

xhaggi commented Dec 30, 2015

@phil65 @ronie mind taking a look.

@Uukrull
Copy link
Contributor

Uukrull commented Dec 30, 2015

Working fine here. Many thanks!

@xhaggi
Copy link
Member Author

xhaggi commented Dec 31, 2015

@ronie updated as you said.

@xhaggi
Copy link
Member Author

xhaggi commented Jan 1, 2016

@ronie good to go in?

@ronie
Copy link
Member

ronie commented Jan 1, 2016

ok as far as i'm concerned.

phil65 added a commit that referenced this pull request Jan 1, 2016
[confluence][fix] get rid of view (ID: 51) in pvr channel window which cause issues with viewtypes
@phil65 phil65 merged commit 4bac6f8 into xbmc:master Jan 1, 2016
@razzeee razzeee added this to the Krypton 17.0-alpha1 milestone Jan 7, 2016
@xhaggi xhaggi deleted the fix-confluence-pvrchannels branch February 5, 2016 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Component: PVR Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants