New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR] Addon API 5.0.0 #8736
[PVR] Addon API 5.0.0 #8736
Conversation
@ksooo thanks, nice additions, I like the idea with the new callback if the state is changed and everything else except the last commit ;) |
@xhaggi see my comment about the last commit. What you fear (not to see progress at all, because startup takes longer than 30 secs) is not true. ;-) |
okay then it's fine by me :) |
70a495f
to
d2472d6
Compare
Feedback from @xhaggi and @FernetMenta incorporated. |
jenkins build this please |
More feedback from @xhaggi incorporated. |
jenkins build this please |
@ksooo great thanks :) next would be dropping the readytouse member but as you said it is something for a separate PR |
and using more friendly method names like |
yeah, but also in another PR |
jenkins build this please |
sure :) |
@ksooo while you're at it, could you remove the |
@Jalle19 good point. Are there more? |
Not sure, I think that's the only one that's completely unused. |
Sorry for hijacking but since PVR is really improving and users are really starting to use the full power of it, is there any interested to work on completing the JSON counterpart so that remotes can use that power too ? Usually I'd talk with Montellese but he have no setup and no real interest in PVR. |
@Tolriq could you please create a forum thread and tell us which parts we neee to expose over json-rpc. that would be highly appreciated. |
http://forum.kodi.tv/showthread.php?tid=255793, will complete later today or tomorrow wife not happy I'm late :p |
Nice. Some pro-active API compatibility attempts by community members. @opdenkamp is wearn down and now KSOO and Xhaggi are the PVR-managers? Glad to find out.. |
Note: pvr.dvblink and pvr.dvbviewer PRs are intentionally missing, because they require a "real" implementation of API 4.2.0 as they actually support timeshifting. Once 4.2.0 has been implemented for these addons I can submit PRs for 5.0.0 |
If nobody objects I will merge this PR tomorrow. |
…turn value for 'no GUI API used'
…s, then retry without UI
…set from outside. (Needed for new async epg data transfer.)
…xample to speedup and simplify lookup of epg events belonging to recordings.
…ields, including respective PVR_ACTUAL_STREAM_*_BR info labels.
Rebased. |
jenkins build this please |
I'd like to propose the following extensions and changes to the PVR Addon API for Krypton:
Addon Maintainer Todo: If GUI lib is not used by the addon, GetGUIAPIVersion and GetMininumGUIAPIVersion should be changed to return "" (empty string). Additionally, addon.xml.in should be changed to not include
Addon Maintainer Todo: no mandatory addon changes. recompile of the addon is sufficient. but feel free to use the new functionality to enhance your addon
Addon Maintainer Todo: change all code that denotes an "invalid" epg tag uid to use the new constant for that purpose
Addon Maintainer Todo: yeah, remove that function
Addon Maintainer Todo: no mandatory addon changes. recompile of the addon is sufficient. but feel free to use the new functionality to enhance your addon
Addon Maintainer Todo: add this function. refer to https://github.com/xbmc/xbmc/pull/8736/files#diff-e73115cc4e6a02ef7029ee04f8ddd2a8R648 for implementation details
Addon Maintainer Todo: no mandatory changes, but highly recommended to fill this field, because it is a prerequisite for performance improvements on the kodi side of things
Addon Maintainer Todo: yeah, just remove this if used in your addon
Addon Maintainer Todo: change all code that denotes an "invalid" channel uid to use the new constant for that purpose
@FernetMenta @Jalle19 others... Feedback welcome