Add rating and votes label for specific rating

[phate89]

Now skins can use directly a label with both votes and ratings.
do someone know if there is a number formatting method in kodi to transform for example
10000
in
10.000?

[razzeee]

I would guess it's best to keep it in line with the other ratings and votes labels and not add 10.000 if the others don't behave that way.

[phate89]

The problem is that in Jarvis (at least in my setup) votes was a string with already built in punctuation (100,000). With my pr andrating as integer I changed how votes are displayed (and IMHO it looks weird too)

[zag2me]

I always prefer to show big numbers with the comma. I do that with all vote counts on the metadata sites so I think Kodi should do the same.

[tamland]

Number formatting is language specific and must be handled in such way. Possibly with std::ios_base::imbue?

[phate89]

@tamland
I'm looking into using a stringstream and imbue but apparently kodi sets a global "*" locale that I can't override so it doesn't work (at least in my win 10). Someone knows better this part of code?

[tamland]

See SetGlobalLocale in LangInfo.cpp, but for some reason it only sets collate because it "breaks atof() others similar functions" (?)

[phate89]

After investigating better I discovered that it's possible to override global locale. It only doesn't work in windows. The problem is here:
https://github.com/xbmc/xbmc/blob/master/xbmc/Application.cpp#L636
before that line everything works well. After it doesn't.
I don't understand why that code also because in windows we use std::locale::global or wsetlocale and not setlocale..
Who knows better? @Karlson2k @Paxxi ?

[phate89]

I guess this could go in since the existing label is already without formatting style. The formatting could be posted in a new pr (once I figure it out how :| )

[phate89]

Updated with explanation string

[razzeee]

jenkins build and merge