[addons] add setting for enabling/disabling zip install

[tamland]

This changes zip install to be handled similar to how Android handles apk installing from unknown sources. I.e when attempting to install a zip, it will take you to the settings where unknown sources must be explicitly enabled.

[razzeee]

Haven't checked the code yet, but I love the idea.

[ronie]

nice!

[MartijnKaijser]

Could you also add file location for the other used strings?

[da-anda]

hmm, shouldn't we rather hide the "install from zip" entry if unknown sources is disabled?

[tamland]

hmm, shouldn't we rather hide the "install from zip" entry if unknown sources is disabled?

No. It's by design, otherwise there will be endless confusion about "where did install from zip go?" We can reevaluate in a release or two.

[da-anda]

how does waiting for a release or two change anything about the confusion?

[MartijnKaijser]

people will follow some shitty youtube video now or in two years so better go the proper way at once

[da-anda]

I'd also like to avoid a "click, click, click click, click, done" situation which we would end up with now. Oh, btw, which button is focused in the "are you sure to enable" dialog? IMO it should be the "no" button so that the user is somewhat forced to read before simply clicking.

[zag2me]

I use install from zip all the time in my testing and so do many others. It should stay visible imo to prevent confusion. It is also there in many wiki guides and online articles (not all piracy related).

I like this solution. The android system is nice and feels more secure.

Most of the piracy Add-ons are installed by adding a repository from the system >> file manager route currently.

[MartijnKaijser]

No they also use install from zip but then from the just added source from file manager. I don't see the issue on hiding it. Once you unable "untrusted" you having it back. Wiki can be updated

[tamland]

Perhaps that was a poor explanation, as I didn't think I had to explain: The purpose of this is to convey a message to the users about the security implications before making the decision of installing an add-on. It's not about removing or hiding this feature. Thus, it's important that "Install from zip" stays visible, including the dialog explaining why it's disabled and where to change it.

There are equally many clicks when going via the side menu. And please, just test it. It will not select the "dangerous" options by default.

[Hedda]

Yes please consider including a more verbose warning text similar to Android, as discussed here:

http://forum.kodi.tv/showthread.php?tid=229648

Linked examples are description text that Amazon and Google use for Enable Unknown Sources:

http://www.amazon.com/gp/help/customer/display.html?nodeId=201482620

https://support.google.com/accounts/answer/2812853

http://developer.android.com/distribute/tools/open-distribution.html

Great work btw!

[tamland]

jenkins build this please

[tamland]

good to go?

[zag2me]

I just tested this on the nightlies and the text needs to be made a lot shorter. At the moment it comes up completely incomprehensible as it starts at the end of the sentience and scrolls over 4 lines.

Suggestion: "It can be potentially dangerous to install Add-ons from outside the official Kodi repository. Would you still like to proceed?"

The feature works well otherwise. A nice addition.

[tamland]

No idea why it's so long for you. Looks like this here:

[tamland]

Nvm. my window's stretched a few pixels which somehow cause the font to be rendered slightly different (my bet's on our glyph positioning hacks) sigh

[da-anda]

just make that dialog bigger. I'd prefer to not shorten it as it currently really scares people off by giving examples of what could happen, while with the version from Zag people just think "whatever" and continue without thinking about the risks themselves.

[razzeee]

@da-anda is right I think

[ronie]

#8994