Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New clothes for Kodi #9235

Merged
merged 6 commits into from Mar 1, 2016

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Feb 28, 2016

So here it is.....Estuary.

Estuary

Not sure if some of the build files need further changes to support multiple themes ?
Also, the language file could need some cleanup, but that could be done afterwards I guess.

Thanks to all involved! :)

@FernetMenta
Copy link
Contributor

Congratulations to all involved making this happen. Great job! This is one of the most important milestones for Kodi for a long time.

@ronie
Copy link
Member

ronie commented Feb 28, 2016

thanx a billion @phil65 (and everyone else involved) for your dedication on this project!

@afedchin
Copy link
Member

can we keep Confluence in repo?

@phil65
Copy link
Contributor Author

phil65 commented Feb 28, 2016

yup, @HitcherUK will take care of it.

@phil65 phil65 force-pushed the bye_bye_confluence_was_nice_to_meet_you branch from a153002 to 6530769 Compare February 28, 2016 20:32
@BigNoid
Copy link
Member

BigNoid commented Feb 28, 2016

Thx @phil65 for the many hours spent creating this skin.

@SLiX69
Copy link

SLiX69 commented Feb 28, 2016

Thanks to all involved, looks awesome!

@koying
Copy link
Contributor

koying commented Feb 28, 2016

Congrats to all involved in this huge endeavor :)

@pietheinstrengholt
Copy link

Worth a post on the frontpage! Congrats!!

@razzeee
Copy link
Member

razzeee commented Feb 28, 2016

+1
Finally, let's merge this!
Thanks, @phil65, @vonH and everybody involved.

@vonH
Copy link

vonH commented Feb 28, 2016

Nice to see this ready.

@ronie
Copy link
Member

ronie commented Feb 29, 2016

Also, the language file could need some cleanup, but that could be done afterwards I guess.

you can cherry-pick ronie@38c0cd7

or just pull the full file https://github.com/ronie/xbmc/blob/estuary-lang/addons/resource.language.en_gb/resources/strings.po

@phil65
Copy link
Contributor Author

phil65 commented Feb 29, 2016

Done.

@MilhouseVH
Copy link
Contributor

How difficult would it be to move the "[Confluence] - bye bye Confluence." commit to a separate PR which could be merged a week or two after this is merged? I might even be able to include this PR in test builds where it not dropping Confluence. I just think this approach might give bleeding edge testers the opportunity to dip their toe into Estuary waters before the hammer comes down...

Edit: If it's a lot of bother or not really practical, then no problem.

@phil65
Copy link
Contributor Author

phil65 commented Feb 29, 2016

The idea is to move Confluence to the skin repository and bump its version number. That way all people get that update and have a copy of confluence in userdata_folder so they wont experience the hammer you mentioned.

@MilhouseVH
Copy link
Contributor

Of course - thanks.

@ghost
Copy link

ghost commented Feb 29, 2016

im guessing we wont be able to try this out on jarvis?

@phil65
Copy link
Contributor Author

phil65 commented Feb 29, 2016

Nope. :)

@ghost
Copy link

ghost commented Feb 29, 2016

ok thx anyway im waiting till feature freeze to go to v17

@vonH
Copy link

vonH commented Feb 29, 2016

It does work on Jarvis, mostly.

@razzeee
Copy link
Member

razzeee commented Feb 29, 2016

But the home screen is basically unusable in Jarvis as we changed a bunch of stuff.

@fritsch
Copy link
Member

fritsch commented Feb 29, 2016

Hurray, really. Looking forward to a fantastic v17. Already rebased my stuff on your branch and it's primetime in my living room. Quite funny, if you were used to "navigate endless times" and now stuff is just there where one expects it.

Thanks to all involved.

@zag2me
Copy link
Contributor

zag2me commented Feb 29, 2016

Stuff like this makes me proud to be part of this awesome team.
Obvious +1 on the inclusion!

@ronie
Copy link
Member

ronie commented Feb 29, 2016

confluence is now available in the addon repo for krypton.
xbmc/repo-skins#2

@stefansaraev
Copy link
Contributor

https://github.com/phil65/xbmc/blob/65307696051e372335ac3f7f371154c98f09038b/addons/skin.estuary/media/Makefile.in#L11 is nope. you meant ifeq (@Arch@,arm) ?

also, -use_none has changed to "-disable_dxt -disable_lzo" in Krypton, but there is not much difference in speed / compression ratio with dxt disabled, you should obviously not diasble lzo. so you may remove this arm check.

EDIT: oh I forgot. dxt is gone. just drop the architecture check ;)

@phil65
Copy link
Contributor Author

phil65 commented Feb 29, 2016

It does work on Jarvis, mostly

Nope, it doesn't work properly at all on Jarvis.

@da-anda
Copy link
Member

da-anda commented Feb 29, 2016

I haven't tested the 3D depths since my initial work on that. I'm sure that some stuff that got added later needs some tweaking, but there is plenty of time to fix that part (don't have the time for it atm anyways)

@phil65
Copy link
Contributor Author

phil65 commented Feb 29, 2016

@stefansaraev done, thx.

@a1rwulf
Copy link
Member

a1rwulf commented Feb 29, 2016

Awesome!
Thx guys for your great work, looking forward to v17 as well.

@phil65 phil65 force-pushed the bye_bye_confluence_was_nice_to_meet_you branch 2 times, most recently from 7ebaa4f to 6f0f476 Compare February 29, 2016 14:06
@phil65
Copy link
Contributor Author

phil65 commented Feb 29, 2016

Squashed all fixups.

@wsnipex
Copy link
Member

wsnipex commented Feb 29, 2016

great stuff 👍

@phil65 phil65 force-pushed the bye_bye_confluence_was_nice_to_meet_you branch from 6f0f476 to 9ea39b2 Compare March 1, 2016 02:23
@phil65 phil65 force-pushed the bye_bye_confluence_was_nice_to_meet_you branch from 9ea39b2 to 16e0c92 Compare March 1, 2016 13:31
@phil65
Copy link
Contributor Author

phil65 commented Mar 1, 2016

@ronie changed and squashed.
jenkins build this please

phil65 added a commit that referenced this pull request Mar 1, 2016
@phil65 phil65 merged commit 034aa80 into xbmc:master Mar 1, 2016
@phil65
Copy link
Contributor Author

phil65 commented Mar 1, 2016

@razzeee razzeee added this to the Krypton 17.0-alpha1 milestone Mar 1, 2016
@razzeee razzeee added the Type: Feature non-breaking change which adds functionality label Mar 1, 2016
@phil65 phil65 deleted the bye_bye_confluence_was_nice_to_meet_you branch March 2, 2016 00:00
@ghost
Copy link

ghost commented Mar 2, 2016

just a suggestion,
when a video has started and you bring up the osd bar for the part that shows media info/plot, plot is the default instead of media info maybe have a option to select media info as default instead of plot, or even bring the media info to the osd area (top right) like with confluence it was nice seeing it. now it requires 3-4 clicks to see it. also 1080p/720p/SD doesnt show in media info anymore :(

also, for some reason i cant select different types of views i do not use library, i just use "Videos" i used to use big list which would hide the thumbnails and plot info. now it says no information available for every file heh. big list would hide that atleast since i dont need it.

@MartijnKaijser
Copy link
Member

@Mazeyx ask on the forum

@robinrossow
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Feature non-breaking change which adds functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet