New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New clothes for Kodi #9235
New clothes for Kodi #9235
Conversation
Congratulations to all involved making this happen. Great job! This is one of the most important milestones for Kodi for a long time. |
thanx a billion @phil65 (and everyone else involved) for your dedication on this project! |
can we keep Confluence in repo? |
yup, @HitcherUK will take care of it. |
a153002
to
6530769
Compare
Thx @phil65 for the many hours spent creating this skin. |
Thanks to all involved, looks awesome! |
Congrats to all involved in this huge endeavor :) |
Worth a post on the frontpage! Congrats!! |
Nice to see this ready. |
you can cherry-pick ronie@38c0cd7 or just pull the full file https://github.com/ronie/xbmc/blob/estuary-lang/addons/resource.language.en_gb/resources/strings.po |
Done. |
How difficult would it be to move the "[Confluence] - bye bye Confluence." commit to a separate PR which could be merged a week or two after this is merged? I might even be able to include this PR in test builds where it not dropping Confluence. I just think this approach might give bleeding edge testers the opportunity to dip their toe into Estuary waters before the hammer comes down... Edit: If it's a lot of bother or not really practical, then no problem. |
The idea is to move Confluence to the skin repository and bump its version number. That way all people get that update and have a copy of confluence in userdata_folder so they wont experience the hammer you mentioned. |
Of course - thanks. |
im guessing we wont be able to try this out on jarvis? |
Nope. :) |
ok thx anyway im waiting till feature freeze to go to v17 |
It does work on Jarvis, mostly. |
But the home screen is basically unusable in Jarvis as we changed a bunch of stuff. |
Hurray, really. Looking forward to a fantastic v17. Already rebased my stuff on your branch and it's primetime in my living room. Quite funny, if you were used to "navigate endless times" and now stuff is just there where one expects it. Thanks to all involved. |
Stuff like this makes me proud to be part of this awesome team. |
confluence is now available in the addon repo for krypton. |
https://github.com/phil65/xbmc/blob/65307696051e372335ac3f7f371154c98f09038b/addons/skin.estuary/media/Makefile.in#L11 is nope. you meant ifeq (@Arch@,arm) ? also, -use_none has changed to "-disable_dxt -disable_lzo" in Krypton, but there is not much difference in speed / compression ratio with dxt disabled, you should obviously not diasble lzo. so you may remove this arm check. EDIT: oh I forgot. dxt is gone. just drop the architecture check ;) |
Nope, it doesn't work properly at all on Jarvis. |
I haven't tested the 3D depths since my initial work on that. I'm sure that some stuff that got added later needs some tweaking, but there is plenty of time to fix that part (don't have the time for it atm anyways) |
@stefansaraev done, thx. |
Awesome! |
7ebaa4f
to
6f0f476
Compare
Squashed all fixups. |
great stuff 👍 |
6f0f476
to
9ea39b2
Compare
9ea39b2
to
16e0c92
Compare
@ronie changed and squashed. |
just a suggestion, also, for some reason i cant select different types of views i do not use library, i just use "Videos" i used to use big list which would hide the thumbnails and plot info. now it says no information available for every file heh. big list would hide that atleast since i dont need it. |
@Mazeyx ask on the forum |
♥ |
So here it is.....Estuary.
Not sure if some of the build files need further changes to support multiple themes ?
Also, the language file could need some cleanup, but that could be done afterwards I guess.
Thanks to all involved! :)