[PVR] Separate TV and Radio recordings #9319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Improvement
ksooo
force-pushed
the
separate-tv-and-radio-recordings
branch
from
2685ac9
to
34b791a
Compare
|
BTW: kodi-pvr/pvr.demo#33 could be used for testing |
|
Please expand to JSON so that remotes can follow :) |
| @@ -39,7 +39,10 @@ CPVRRecordings::CPVRRecordings(void) : | |||
| m_bIsUpdating(false), | |||
| m_iLastId(0), | |||
| m_bGroupItems(true), | |||
| m_bHasDeleted(false) | |||
| m_bHasDeletedTV(false), | |||
| m_bHasDeletedRadio(false), | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
apart from my comments nice improvement. Thanks for all your work so far which makes me happier from day to day :) |
| @@ -56,10 +60,12 @@ namespace PVR | |||
|
|
|||
| private: | |||
| static std::string TrimSlashes(const std::string &strString); | |||
| size_t GetDirectoryPathStart() const; | |||
|
|
|||
| bool m_bValid; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
separate-tv-and-radio-recordings
branch
from
34b791a
to
4e5d0d7
Compare
|
changes requested by @xhaggi are now in. |
|
jenkins build this please |
|
jenkins build error is unrelated (pvr.mythtv fails because it's not yet adapted to pvr api 5.1.0) |
ksooo
added a commit
that referenced
this pull request
Mar 12, 2016
[PVR] Separate TV and Radio recordings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PVR API 5.1.0 pvr clients may provide the channel type (radio/tv) for recordings making it finally possible to distinguish between radio and tv recordings.
@xhaggi mind taking a look