Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] Bumped min. SDK to 19, Fixed PeripherialBusAndroid crash #9517

Merged
merged 1 commit into from Apr 1, 2016
Merged

[android] Bumped min. SDK to 19, Fixed PeripherialBusAndroid crash #9517

merged 1 commit into from Apr 1, 2016

Conversation

dan1j3l
Copy link
Contributor

@dan1j3l dan1j3l commented Apr 1, 2016

  • Bumped minimum required SDK from 17 to 19 (due to usage of some functions that are not available in lower levels)
  • Fixed PeripherialBusAndroid crash on affected devices
  • Changed used function from SDK 21 to one available in SDK 19
  • Commented functions/methods unavailable in SDK 19

@dan1j3l
[android] Bumped min. SDK to 19, Fixed PeripherialBusAndroid crash
54f9c50 
- Bumped minimum required SDK from 17 to 19 (due to usage of some functions that are not available in lower levels)
- Fixed PeripherialBusAndroid crash on affected devices
- Changed used function from SDK 21 to one available in SDK 19
- Commented functions/methods unavailable in SDK 19
@MartijnKaijser
Copy link
Member

Great thx :)
jenkins build this please

An option would be to detect with if(GetSDKVersion() >= 19) and act accordingly (see couple lines downwards in same file) though that something for later to fix up. For now we can get started with this

@MartijnKaijser MartijnKaijser merged commit 0436322 into xbmc:master Apr 1, 2016
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-alpha1 milestone Apr 1, 2016
@dan1j3l
Copy link
Contributor Author

dan1j3l commented Apr 1, 2016

That was fast, now into fixing other things. :)

@dan1j3l dan1j3l deleted the android_sdk_fixes branch April 1, 2016 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: Android v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan1j3l @MartijnKaijser