Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chop out anything before Android 5 and don't build with amlogic #9688

Merged
merged 2 commits into from Apr 26, 2016

Conversation

MartijnKaijser
Copy link
Member

@MartijnKaijser MartijnKaijser commented Apr 26, 2016

Reasoning:

  • Android only started maturing after Android 5.0 as well as the devices
  • AMLogic was the main codec used in the initial Android port however now it's now time to follow the official Android API. AMLogic doesn't completely follow this and that causes a lot of IFDEF / hacks to support both.
  • We are too low on manpower to keep supporting hacks on this platform and the only sane way forward is following the official Android API.

The code is still there for now. This patch will simply stop compiling AMLogic for the Android platform. Should no one pick this up it will be completely removed for Android but could still be used for Linux. AMLogic code needs a complete rewrite anyway.

@MartijnKaijser
Copy link
Member Author

fyi we should include this in Alpha1

@MartijnKaijser MartijnKaijser merged commit f265fc7 into xbmc:master Apr 26, 2016
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-alpha1 milestone Apr 26, 2016
@xbmc xbmc locked and limited conversation to collaborators Apr 26, 2016
@MartijnKaijser MartijnKaijser deleted the goodbye branch June 10, 2016 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants