@wip #77 mitigate some bugs from sonarcloud reports

xcesco · Nov 23, 2020 · 46fa593 · 46fa593
1 parent 967dcc3
commit 46fa593
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 46 deletions.
diff --git a/kripton-android-library/pom.xml b/kripton-android-library/pom.xml
@@ -39,45 +39,20 @@
 
 	<!-- common part - END -->
 	<build>
-
-
 		<plugins>
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-surefire-plugin</artifactId>
 				<version>3.0.0-M5</version>
 				<configuration>
-					<parallel>methods</parallel>
-					<threadCount>10</threadCount>
 					<systemPropertyVariables>
 						<kripton.debug>${kripton.debug}</kripton.debug>
 					</systemPropertyVariables>
 					<includes>
 						<include>all/*TestSuite.java</include>
 					</includes>
-
 				</configuration>
 			</plugin>
-
-			<!-- <plugin>
-				<groupId>org.jacoco</groupId>
-				<artifactId>jacoco-maven-plugin</artifactId>
-				<executions>
-					<execution>
-						<id>prepare-agent</id>
-						<goals>
-							<goal>prepare-agent</goal>
-						</goals>
-					</execution>
-					<execution>
-						<id>report</id>
-						<goals>
-							<goal>report</goal>
-						</goals>
-					</execution>
-				</executions>
-			</plugin> -->
-
 		</plugins>
 	</build>
 

diff --git a/kripton-android-library/src/test/java/sqlite/feature/pkstring/TestPkString1Runtime.java b/kripton-android-library/src/test/java/sqlite/feature/pkstring/TestPkString1Runtime.java
@@ -42,28 +42,23 @@ public class TestPkString1Runtime extends BaseAndroidTest {
 	public void testRun() {			
 		BindPersonCirtyDataSource instance=BindPersonCirtyDataSource.getInstance();
 
-		instance.executeBatch(new Batch<Void>() {
+		instance.executeBatch((Batch<Void>) daoFactory -> {
+			City city=new City();
+			city.id="Oxford";
+			city.name="City of Oxford";
 
-			@Override
-			public Void onExecute(BindPersonCirtyDaoFactory daoFactory) {
-				City city=new City();
-				city.id="Oxford";
-				city.name="City of Oxford";
-
-				daoFactory.getCityDao().insert(city);
-
-				Person person=new Person();
-				person.name="Manero Tonj";
-
-				daoFactory.getPersonDao().insert(person);
-
-				PersonCity m2m=new PersonCity(0,person.id, city.id );				
-
-				daoFactory.getPersonCityDao().insert(m2m);
-
-				return null;
-			}
-
+			daoFactory.getCityDao().insert(city);
+
+			Person person=new Person();
+			person.name="Manero Tonj";
+
+			daoFactory.getPersonDao().insert(person);
+
+			PersonCity m2m=new PersonCity(0,person.id, city.id );
+
+			daoFactory.getPersonCityDao().insert(m2m);
+
+			return null;
 		});
 	}