Fix for the issues when parent element has a CSS scale transform applied to it #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathodsanjay
commented
Nov 28, 2018
| let temp = this.currTrans.value; | ||
| temp.x = temp.x * this.scale; | ||
| temp.y = temp.y * this.scale; | ||
| this.oldTrans.set(new Position(temp.x, temp.y)); |
There was a problem hiding this comment.
@xieziyu - you may want to optimize this block or may have a better approach for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue: #31 - when the parent of the element which is being dragged has a CSS scale transform applied to it, the element and the cursor become de-synced.
The issue is fixed by dividing the translated X and Y coordinates by the scale. However this also needed some changes to be made to the old coordinates (
oldTrans) in order to prevent the element from bouncing off in some scenarios.