Fixes broken date in MySQL 8 #1104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
added
needs discussion
kidunot89
changed the title
kasparsd
reviewed
Jun 11, 2020
kasparsd
reviewed
Jun 11, 2020
|
@kasparsd Unit test added |
kidunot89
removed
needs discussion
kidunot89
force-pushed
the
bugfix/record-created-timestamp
branch
from
1ec1403
to
646875b
Compare
|
Opening a new pull request since I'm unable to make updates to the current source branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091
Replaces old
sprintf( ... )formatting logic with$date->format( DateTime::ATOM )to create the ISO 8601 formatted timestamp to be used in the record.