Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments connector test implemented #1134

Merged
merged 7 commits into from Jan 12, 2021
Merged

Comments connector test implemented #1134

merged 7 commits into from Jan 12, 2021

Conversation

kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Jul 9, 2020 •
edited

Partially fixes #1093

Summary checklist

  • Adds delete_comment callback test
  • Adds edit_comment callback test
  • Adds spam_comment callback test
  • Adds transition_comment_status callback test
  • Adds trash_comment callback test
  • Adds untrash_comment callback test
  • Adds wp_insert_comment callback test
  • Adds comment_duplicate_trigger callback test

@kidunot89 kidunot89 self-assigned this Jul 9, 2020
@kidunot89 kidunot89 added the work in progress Issue or pull request is still under development (DO NOT MERGE) label Jul 9, 2020
@kidunot89 kidunot89 changed the title Comments connector test implemented WIP Comments connector test implemented Jul 23, 2020
@kidunot89 kidunot89 requested a review from kopepasah July 24, 2020 17:17
@kidunot89 kidunot89 added the needs discussion The issue/PR needs further discussion before a solution can be implemented label Jul 30, 2020
@kopepasah kopepasah added this to Doing in Kanban Jul 30, 2020
kasparsd
kasparsd approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these tests!

docker-compose.yml Outdated
@@ -20,7 +20,7 @@ services:
- mysql
- db_phpunit
ports:
- "80:80"
- "8080:80"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep using port 80 for consistency with the developer docs? Currently they're referencing stream.local without the port number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, must have forgot to change it back. I'll be sure to fix it when I rebase

Kanban automation moved this from Doing to Approved Aug 14, 2020
@kidunot89 kidunot89 changed the title WIP Comments connector test implemented Comments connector test implemented Dec 11, 2020
@kidunot89 kidunot89 requested review from ivankruchkoff and kasparsd and removed request for kopepasah December 11, 2020 23:10
@kidunot89 kidunot89 added this to the 3.6.1 milestone Jan 4, 2021
@kidunot89 kidunot89 removed needs discussion The issue/PR needs further discussion before a solution can be implemented work in progress Issue or pull request is still under development (DO NOT MERGE) labels Jan 4, 2021
@kidunot89 kidunot89 merged commit 2569ec8 into develop Jan 12, 2021
Kanban automation moved this from Approved to Done Jan 12, 2021
@kidunot89 kidunot89 deleted the tests/comments-connector branch January 12, 2021 21:45
@kidunot89 kidunot89 mentioned this pull request Jan 12, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekherman derekherman Awaiting requested review from derekherman

@ivankruchkoff ivankruchkoff Awaiting requested review from ivankruchkoff

@kasparsd kasparsd Awaiting requested review from kasparsd

Assignees

@kidunot89 kidunot89

Labels
None yet
Projects
Kanban
  
Done
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Improve Test Coverage
2 participants
@kidunot89 @kasparsd