Set min. PHP version in Composer config #1311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
reviewed
Mar 8, 2022
| @@ -11,6 +11,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^5.3", | |||
There was a problem hiding this comment.
The platform PHP further down the file is set to 5.6.20 which matches the minimum version of WP core https://wordpress.org/about/requirements/
WordPress also works with PHP 5.6.20+ and MySQL 5.0+, but these versions have reached official End Of Life and as such may expose your site to security vulnerabilities.
Should we set this to >=5.6.20 then?
The goal is to support every PHP from 5.6.20 to 8.x.
There was a problem hiding this comment.
I'm not familiar with this project.
Line 34 in 1b30829
This line contains 5.3
Please decide what to do!
A month ago my default changed to PHP 8.0
and WP stats show 6.9% non-PHP7 versions https://wordpress.org/about/stats/#php_versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just that.