Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deprecated filter. #1415

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ethanclevenger91
Copy link

Fixes #1343 .

Describe your approach and how it fixes the issue.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Change: Remove deprecated filter constant.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

@ethanclevenger91
Copy link
Author

I honestly don't exactly understand what the purpose of this array of class-specific constants is. They seem to be re-implementations of available PHP core constants.

I updated references to FILTER_SANITIZE_STRING to use FILTER_SANITIZE_SPECIAL_CHARS, which is keyed to htmlspecialchars, which is the documented alternative

@ethanclevenger91 ethanclevenger91 marked this pull request as ready for review March 22, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1: Constant WP_Stream\FILTER_SANITIZE_STRING is deprecated
1 participant