Move count_users out of roles foreach
#964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidCramer
reviewed
Apr 3, 2018
classes/class-settings.php
Outdated
| @@ -817,13 +817,14 @@ public function render_field( $field ) { | |||
| // Author or Role dropdown menu | |||
| $author_or_role_values = array(); | |||
| $author_or_role_selected = array(); | |||
| $users = count_users(); | |||
There was a problem hiding this comment.
@frozzare You can move this even higher up, outside the foreach of the exclude_row. Perhaps place it at the beginning of the rule_list case.
DavidCramer
requested changes
Apr 3, 2018
|
Done! |
DavidCramer
reviewed
Apr 3, 2018
classes/class-settings.php
Outdated
| @@ -771,6 +771,7 @@ public function render_field( $field ) { | |||
|
|
|||
| break; | |||
| case 'rule_list': | |||
| $users = count_users(); | |||
| $form = new Form_Generator(); | |||
| $output = '<p class="description">' . esc_html( $description ) . '</p>'; | |||
There was a problem hiding this comment.
Cool. Could you please align the = so the build can pass ;)
DavidCramer
reviewed
Apr 3, 2018
classes/class-settings.php
Outdated
| @@ -823,7 +824,7 @@ public function render_field( $field ) { | |||
| 'value' => $role_id, | |||
| 'text' => $role, | |||
| ); | |||
| $users = count_users(); | |||
|
|
|||
DavidCramer
requested changes
Apr 3, 2018
There was a problem hiding this comment.
@frozzare if you can address those two formatting issues, we'll be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will move
count_usersout of roles foreach since it's expensive to call for every role. See #949 for more information.This time against develop instead of master.