Use copy-property pattern for NSString config options

Signed-off-by: Joshua Vickery <josh@yfactorial.com>
yfactorial · Mar 11, 2009 · 07b0add · 07b0add
1 parent a181fed
commit 07b0add
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/Classes/lib/NSObject+ObjectiveResource.m b/Classes/lib/NSObject+ObjectiveResource.m
@@ -29,23 +29,32 @@ + (NSString *)getRemoteSite {
 }
 
 + (void)setRemoteSite:(NSString *)siteURL {
-	_activeResourceSite = siteURL;
+	if (_activeResourceSite != siteURL) {
+		[_activeResourceSite autorelease];
+		_activeResourceSite = [siteURL copy];
+	}
 }
 
 + (NSString *)getRemoteUser {
 	return _activeResourceUser;
 }
 
 + (void)setRemoteUser:(NSString *)user {
-	_activeResourceUser = user;
+	if (_activeResourceUser != user) {
+		[_activeResourceUser autorelease];
+		_activeResourceUser = [user copy];
+	}
 }
 
 + (NSString *)getRemotePassword {
 	return _activeResourcePassword;
 }
 
 + (void)setRemotePassword:(NSString *)password {
-	_activeResourcePassword = password;
+	if (_activeResourcePassword != password) {
+		[_activeResourcePassword autorelease];
+		_activeResourcePassword = [password copy];
+	}
 }
 
 + (void)setRemoteResponseType:(ORSResponseFormat) format {
@@ -89,7 +98,10 @@ + (NSString *)getRemoteProtocolExtension {
 }
 
 + (void)setRemoteProtocolExtension:(NSString *)protocolExtension {
-	_activeResourceProtocolExtension = protocolExtension;
+	if (_activeResourceProtocolExtension != protocolExtension) {
+		[_activeResourceProtocolExtension autorelease];
+		_activeResourceProtocolExtension = [protocolExtension copy];
+	}
 }