Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JSON pretty print for ElasticSearch bulk API #344

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

rhertogh
Copy link
Contributor

@rhertogh rhertogh commented Jul 10, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

This PR disables JSON pretty print for ElasticSearch bulk API since it uses new lines as delimiter.
From the ElasticSearch bulk API documentation:

Because this format uses literal \n's as delimiters, make sure that the JSON actions and sources are not pretty printed.

@what-the-diff
Copy link

what-the-diff bot commented Jul 10, 2023

PR Summary

  • Enhancement of JSON encoding in the Yii framework's BulkCommand
    The developer team has implemented a feature that improves the presentation of JSON encoded data when using the BulkCommand in the Yii framework, a popular PHP framework. This enhancement, known as "pretty printing," enhances the readability of the data by implementing a more organized, multi-line format. This change will cater to improved debugging and interaction with the JSON data, thus accelerating the problem-solving speed and efficacy.

@rhertogh rhertogh marked this pull request as ready for review July 10, 2023 14:43
@beowulfenator beowulfenator merged commit b15c795 into yiisoft:master Jul 10, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants