[on.orf.at] better/more data parsing #9677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxCoder
force-pushed
the
on_orf_at_more_parsing
branch
from
68ae87a
to
e3192e8
Compare
added 5 commits
April 12, 2024 23:14
use the linked subtitles in the v4.3 api
some urls are without slug also some video-Id's are shorter that 8 digits and could probably be bigger than 8
some videos formats are not reported as DRM protected fixes: yt-dlp#9652
this test file has no kill_date, so I hope it will be online for longer old one would be not available after "2024-08-12T21:05:00+02:00"
TuxCoder
force-pushed
the
on_orf_at_more_parsing
branch
from
e3192e8
to
f51d16b
Compare
seproDev
added
site-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
example for 7 digits: https://on.orf.at/video/3229173
the new test data has
killdate: Noneas attribute, so this should be more stable for the futuresadly I did't found any video with age restriction and
right: "worldwide"only with restriction to Austria and/or with akilldate< 2025, IMHO not worth to add as will create future problemTemplate
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Open Questions:
'xml', 'srt', 'sami', 'ttml', 'stl'that are available so I comment them outdisplay_idbe remove?! as it is not included with all urls fromon.orf.atAs this is my first PR to
yt-dlpI hope I didn't oversaw anything from the good written guidelines.If so feel free to point that out.