Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for live truTV streams #9683

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ischmidt20
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds support to the tbs extractor for live truTV streams (e.g., https://www.trutv.com/watchtrutv/east). To be honest, this might belong in the separate truTV extractor, but as the TNT live streams were already here, it was easier for me to follow along to add truTV.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan
Copy link
Member

Is there an open issue for this? And pls add a test

@ischmidt20
Copy link
Contributor Author

No open issue, I just noticed it myself because truTV follows same format as TBS and TNT but extractor was only set up to handle TBS/TNT. Adding test shortly

@seproDev seproDev added the site-enhancement Feature request for some website label Apr 20, 2024
yt_dlp/extractor/tbs.py Show resolved Hide resolved
@bashonly
Copy link
Member

bashonly commented May 8, 2024

It looks like truTV has adopted the same backend and URL format as TBS/TNT for its episodes and clips as well. The other extractor in trutv.py is obsolete: there is no way to find URLs on the trutv website that are matched by the old extractor; however, the old API seems to be still operational in a legacy capacity and thus the old extractor's test still works.

It's probably not necessary to remove the old trutv extractor yet, but perhaps we should add a comment to clarify its situation. And we should probably return _old_archive_ids in the TBS extractor if site == trutv since the video IDs appear to be the same as before

@bashonly bashonly self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants