Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markiza.py #9693

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update markiza.py #9693

wants to merge 1 commit into from

Conversation

kubo6472
Copy link

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #9692

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-bug Issue with a specific website label Apr 20, 2024
@bashonly
Copy link
Member

Is this just copy and pasting code from the Nova extractors? It would be better to create a NovaBaseIE and subclass NovaIE and MarkizaIE from it etc

@bashonly bashonly added the pending-fixes PR has had changes requested label May 11, 2024
@kubo6472
Copy link
Author

Since mid-april, both sites run the same player. It should be just the Nova extractor with two additional domains: markíza.sk and tvnoviny.sk

@bashonly
Copy link
Member

Then let's do that and remove MarkizaIE etc instead of duplicating code

@kubo6472
Copy link
Author

Aight, I'm gonna close this then.

@bashonly
Copy link
Member

You can revert and continue to push to this branch. It would be preferred, actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-fixes PR has had changes requested site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markíza.py not working
3 participants