Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/pbs] Accepts pbssocal (#8703) #9740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n10dollar
Copy link

@n10dollar n10dollar commented Apr 20, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

closes #8703

Fixes a tiny issue where pbs URLs were accepted but not pbssocal URLs. The accepted string group "pbs" was simply changed to "(pbs|pbssocal)". The issue was solved earlier but the contributer didn't seem to follow through with the PR.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@n10dollar n10dollar closed this Apr 20, 2024
@n10dollar n10dollar reopened this Apr 20, 2024
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test with the newly supported domain

@@ -189,7 +189,7 @@ class PBSIE(InfoExtractor):
# Direct video URL
(?:%s)/(?:(?:vir|port)alplayer|video)/(?P<id>[0-9]+)(?:[?/]|$) |
# Article with embedded player (or direct video)
(?:www\.)?pbs\.org/(?:[^/]+/){1,5}(?P<presumptive_id>[^/]+?)(?:\.html)?/?(?:$|[?\#]) |
(?:www\.)?(pbs|pbssocal)\.org/(?:[^/]+/){1,5}(?P<presumptive_id>[^/]+?)(?:\.html)?/?(?:$|[?\#]) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(?:www\.)?(pbs|pbssocal)\.org/(?:[^/]+/){1,5}(?P<presumptive_id>[^/]+?)(?:\.html)?/?(?:$|[?\#]) |
(?:www\.)?pbs(?:socal)?\.org/(?:[^/]+/){1,5}(?P<presumptive_id>[^/]+?)(?:\.html)?/?(?:$|[?\#]) |

@bashonly bashonly added site-enhancement Feature request for some website pending-fixes PR has had changes requested labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-fixes PR has had changes requested site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PBS SoCal Extractor
2 participants