Add web workers, parse automatically #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| web/content/assets/js/jison.js | ||
| web/crash.log |
There was a problem hiding this comment.
nanoc kept creating this file for some reason ^
I thought the demo might be nicer if it used web workers to parse the grammar in the background. That way it doesn't block the DOM, so it's a bit smoother. Additionally, since we're not blocking the DOM, we can just automatically re-parse the file as the user types. I set a debounce of 700ms so that it doesn't fire too frequently. I also removed the "Generate" button entirely, and set it up so there's a little "Parsing..." message while it's parsing. I also made to sure to do a fallback if web workers aren't supported in the browser (and I tested that it works). You can try a demo [here](https://nolanlawson.s3.amazonaws.com/jison/try/index.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the demo might be nicer if it used web workers
to parse the grammar in the background. That way it doesn't
block the DOM, so it's a bit smoother.
Additionally, since we're not blocking the DOM, we can just
automatically re-parse the file as the user types. I set a
debounce of 700ms so that it doesn't fire too frequently. I also
removed the "Generate" button entirely, and set it up so there's a little
"Parsing..." message while it's parsing. I also made to sure to do
a fallback if web workers aren't supported in the browser (and I tested
that it works).
You can try a demo here.