proxy: use buffer pool to copy response #2228
Open
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexanderYastrebov what is missing to finish this? |
AlexanderYastrebov
force-pushed
the
proxy/buffer-pool
branch
from
0fdda80
to
6747281
Compare
|
You have successfully added a new GoKart configuration |
Similar change in stdlib golang/go#58452 was rolled back due to golang/go#58446 which is fixed now and is scheduled for 1.21. I was not sure if we should proceed or maybe wait until 1.21. Feature-wise it is complete. |
|
Ok then let's wait for 1.21 |
5 tasks
AlexanderYastrebov
force-pushed
the
proxy/buffer-pool
branch
from
6747281
to
de23d34
Compare
|
👍 |
AlexanderYastrebov
force-pushed
the
proxy/buffer-pool
branch
from
de23d34
to
65fcc21
Compare
AlexanderYastrebov
added
major
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
```
goos: linux
goarch: amd64
pkg: github.com/zalando/skipper/proxy
cpu: Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
│ /tmp/BenchmarkCopyStream.old │ /tmp/BenchmarkCopyStream.new │
│ sec/op │ sec/op vs base │
CopyStream/size_100-8 2662.5n ± 13% 163.8n ± 3% -93.85% (p=0.000 n=10)
CopyStream/size_1000-8 2696.5n ± 6% 163.8n ± 0% -93.93% (p=0.000 n=10)
CopyStream/size_10000-8 2842.0n ± 6% 163.8n ± 0% -94.24% (p=0.000 n=10)
CopyStream/size_100000-8 2731.0n ± 2% 163.8n ± 0% -94.00% (p=0.000 n=10)
CopyStream/size_1000000-8 2760.5n ± 1% 163.9n ± 0% -94.06% (p=0.000 n=10)
CopyStream/size_10000000-8 2678.0n ± 3% 163.9n ± 3% -93.88% (p=0.000 n=10)
geomean 2.728µ 163.8n -94.00%
│ /tmp/BenchmarkCopyStream.old │ /tmp/BenchmarkCopyStream.new │
│ B/op │ B/op vs base │
CopyStream/size_100-8 8208.00 ± 0% 16.00 ± 0% -99.81% (p=0.000 n=10)
CopyStream/size_1000-8 8208.00 ± 0% 16.00 ± 0% -99.81% (p=0.000 n=10)
CopyStream/size_10000-8 8208.00 ± 0% 16.00 ± 0% -99.81% (p=0.000 n=10)
CopyStream/size_100000-8 8208.00 ± 0% 16.00 ± 0% -99.81% (p=0.000 n=10)
CopyStream/size_1000000-8 8208.00 ± 0% 16.00 ± 0% -99.81% (p=0.000 n=10)
CopyStream/size_10000000-8 8208.00 ± 0% 16.00 ± 0% -99.81% (p=0.000 n=10)
geomean 8.016Ki 16.00 -99.81%
│ /tmp/BenchmarkCopyStream.old │ /tmp/BenchmarkCopyStream.new │
│ allocs/op │ allocs/op vs base │
CopyStream/size_100-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
CopyStream/size_1000-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
CopyStream/size_10000-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
CopyStream/size_100000-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
CopyStream/size_1000000-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
CopyStream/size_10000000-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
geomean 2.000 1.000 -50.00%
```
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
proxy/buffer-pool
branch
from
65fcc21
to
b171d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also golang/go#58452 golang/go#58446