Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the unicode compatibility between Python 2 and 3 #13

Merged
merged 3 commits into from Aug 15, 2017
Merged

Improve the unicode compatibility between Python 2 and 3 #13

merged 3 commits into from Aug 15, 2017

Conversation

sallner
Copy link
Member

@sallner sallner commented Aug 11, 2017

In some tests in five.formlib utf-8 encoded unicode is passed to the widget. With this PR this works under python 2 and 3.

@sallner sallner changed the base branch from cleanup-test-setup to master August 11, 2017 11:12
@sallner sallner requested a review from icemac August 14, 2017 11:28
icemac
icemac approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a changelog entry would be nice, too.

@sallner sallner merged commit 22096ae into master Aug 15, 2017
@sallner
Copy link
Member Author

sallner commented Aug 15, 2017

Added a changelog entry and merged it.

@sallner sallner deleted the decode-compatibitlity branch August 15, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sallner @icemac