Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last commit #3

Closed
wants to merge 1 commit into from
Closed

last commit #3

wants to merge 1 commit into from

Conversation

zurk
Copy link
Owner

@zurk zurk commented Oct 2, 2018

Summary

Checklist

zurk
zurk commented Oct 2, 2018
View reviewed changes
test/data/testinit.js
// Otherwise it's easy to write tests that pass on test/index.html
// but fail in Karma runner (where the baseURL is different).
var baseURL = "data/",
var FILEPATH = "/test/data/testinit.js",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

var FILEPATH = "/test/data/testinit.js",

Replace <space> with <+tab> at column 4.
Confidence: 0.983
Triggered rule jquery#26:

    left_1_diff_line > 0.500
    right_0_length > 1.500
    left_3_reserved in |;|
    left_0_internal_type in |stringliteral|
    left_2_reserved in |;|
    left_1_label in |<newline>|
    left_0_reserved in |;|
    right_0_roles in |function˙literal|
    left_0_label in |<space>|

test/data/testinit.js
var baseURL = "data/",
var FILEPATH = "/test/data/testinit.js",
activeScript = [].slice.call( document.getElementsByTagName( "script" ), -1 )[ 0 ],
parentUrl = activeScript && activeScript.src ?
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

	parentUrl = activeScript && activeScript.src ?

Replace <newline> with <space> at column 48.
Confidence: 0.954
Triggered rule jquery#64:

    left_1_diff_line ≤ 0.500
    left_0_internal_type in |commentline˙stringliteral|
    right_0_reserved in |}|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_0_internal_type in |variabledeclaration|
    right_1_roles in |comment|
    left_0_label in |<space>|

test/data/testinit.js
var FILEPATH = "/test/data/testinit.js",
activeScript = [].slice.call( document.getElementsByTagName( "script" ), -1 )[ 0 ],
parentUrl = activeScript && activeScript.src ?
activeScript.src.replace( /[?#].*/, "" ) + FILEPATH.replace( /[^/]+/g, ".." ) + "/" :
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

		activeScript.src.replace( /[?#].*/, "" ) + FILEPATH.replace( /[^/]+/g, ".." ) + "/" :

Replace <newline> with <space> at column 88.
Confidence: 0.954
Triggered rule jquery#64:

    left_1_diff_line ≤ 0.500
    left_0_internal_type in |commentline˙stringliteral|
    right_0_reserved in |}|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_0_internal_type in |variabledeclaration|
    right_1_roles in |comment|
    left_0_label in |<space>|

test/data/testinit.js
activeScript.src.replace( /[?#].*/, "" ) + FILEPATH.replace( /[^/]+/g, ".." ) + "/" :
"../",

// baseURL is intentionally set to "data/" instead of "".
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

	// baseURL is intentionally set to "data/" instead of "".

Replace <-tab> with <+tab> at column 1.
Confidence: 0.983
Triggered rule jquery#26:

    left_1_diff_line > 0.500
    right_0_length > 1.500
    left_3_reserved in |;|
    left_0_internal_type in |stringliteral|
    left_2_reserved in |;|
    left_1_label in |<newline>|
    left_0_reserved in |;|
    right_0_roles in |function˙literal|
    left_0_label in |<space>|

test/unit/ajax.js
return [
{
url: baseURL + "name.html#foo",
beforeSend: function( xhr, settings ) {
assert.equal( settings.url, baseURL + "name.html#foo", "Make sure that the URL has its hash." );
assert.equal( settings.url, baseURL + "name.html#foo",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

					assert.equal( settings.url, baseURL + "name.html#foo",

Replace <newline> with <space> at column 60.
Confidence: 0.954
Triggered rule jquery#64:

    left_1_diff_line ≤ 0.500
    left_0_internal_type in |commentline˙stringliteral|
    right_0_reserved in |}|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_0_internal_type in |variabledeclaration|
    right_1_roles in |comment|
    left_0_label in |<space>|

test/unit/ajax.js
// Clear the cache-buster param value
var url = settings.url.replace( /_=[^&#]+/, "_=" );
assert.equal( url, baseURL + "name.html?abc&devo=hat&_=#brownies",
"hash preserved for cache-busting request with query component and data." );
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

						"hash preserved for cache-busting request with query component and data." );

Replace " with <space> at column 7.
Confidence: 0.954
Triggered rule jquery#64:

    left_1_diff_line ≤ 0.500
    left_0_internal_type in |commentline˙stringliteral|
    right_0_reserved in |}|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_0_internal_type in |variabledeclaration|
    right_1_roles in |comment|
    left_0_label in |<space>|

test/unit/ajax.js
@@ -1146,7 +1150,7 @@ QUnit.module( "ajax", {
setup: function() {
Globals.register( "testBar" );
},
url: window.location.href.replace( /[^\/]*$/, "" ) + baseURL + "mock.php?action=testbar",
url: url( "mock.php?action=testbar" ),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

			url: url( "mock.php?action=testbar" ),

Replace <newline> with <space> at column 42.
Confidence: 0.843
Triggered rule jquery#55:

    node_start_col > 19.500
    left_1_diff_line ≤ 0.500
    right_0_length ≤ 4.500
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    right_1_internal_type in |stringliteral|
    left_0_label in |<space>|

test/unit/ajax.js
} else {
absoluteUrl = window.location.href.replace( /[^/]*$/, "" ) + absoluteUrl;
}
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

		}

Replace <newline> with <space> at column 4.
Confidence: 0.954
Triggered rule jquery#64:

    left_1_diff_line ≤ 0.500
    left_0_internal_type in |commentline˙stringliteral|
    right_0_reserved in |}|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_0_internal_type in |variabledeclaration|
    right_1_roles in |comment|
    left_0_label in |<space>|

Gruntfile.js
{ pattern: "dist/jquery.js", included: false, served: true },
{ pattern: "dist/*.map", included: false, served: true },
{ pattern: "external/qunit/qunit.css", included: false, served: true },
{ pattern: "dist/jquery.*", included: false, served: true },
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

					{ pattern: "dist/jquery.*", included: false, served: true },

Replace <space> with <newline> at column 7.
Confidence: 0.673
Triggered rule jquery#40:

    left_1_diff_line ≤ 0.500
    right_4_length > 3.500
    left_0_internal_type in |stringliteral|
    left_0_reserved in |;˙{|
    right_2_roles in |value|
    left_0_label in |<space>|

Replace <space> with <newline> at column 33.
Confidence: 0.921
Triggered rule jquery#53:

    node_start_col ≤ 33.500
    left_1_diff_line ≤ 0.500
    right_0_length > 4.500
    left_3_reserved in |[|
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    left_0_label in |<space>|

Replace <space> with <newline> at column 50.
Confidence: 0.727
Triggered rule jquery#51:

    node_start_col > 33.500
    left_1_diff_line ≤ 0.500
    right_0_length > 4.500
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_1_internal_type in |callexpression|
    left_0_label in |<space>|

Replace <newline> with <space> at column 66.
Confidence: 0.843
Triggered rule jquery#55:

    node_start_col > 19.500
    left_1_diff_line ≤ 0.500
    right_0_length ≤ 4.500
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    right_1_internal_type in |stringliteral|
    left_0_label in |<space>|

Gruntfile.js
{ pattern: "dist/*.map", included: false, served: true },
{ pattern: "external/qunit/qunit.css", included: false, served: true },
{ pattern: "dist/jquery.*", included: false, served: true },
{ pattern: "src/**", included: false, served: true },
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format: style mismatch:

					{ pattern: "src/**", included: false, served: true },

Replace <space> with <newline> at column 7.
Confidence: 0.673
Triggered rule jquery#40:

    left_1_diff_line ≤ 0.500
    right_4_length > 3.500
    left_0_internal_type in |stringliteral|
    left_0_reserved in |;˙{|
    right_2_roles in |value|
    left_0_label in |<space>|

Replace <space> with <newline> at column 26.
Confidence: 0.921
Triggered rule jquery#53:

    node_start_col ≤ 33.500
    left_1_diff_line ≤ 0.500
    right_0_length > 4.500
    left_3_reserved in |[|
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    left_0_label in |<space>|

Replace <space> with <newline> at column 43.
Confidence: 0.727
Triggered rule jquery#51:

    node_start_col > 33.500
    left_1_diff_line ≤ 0.500
    right_0_length > 4.500
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    parents_1_internal_type in |callexpression|
    left_0_label in |<space>|

Replace <newline> with <space> at column 59.
Confidence: 0.843
Triggered rule jquery#55:

    node_start_col > 19.500
    left_1_diff_line ≤ 0.500
    right_0_length ≤ 4.500
    left_0_internal_type in |commentline˙stringliteral|
    left_0_reserved in |;˙{|
    parents_0_roles in |literal|
    right_1_internal_type in |stringliteral|
    left_0_label in |<space>|

@zurk zurk closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@zurk