-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): dockerfiles improvements and fixes #1792
Open
qdm12
wants to merge
13
commits into
zylon-ai:main
Choose a base branch
from
qdm12:qdm12/dockerfile-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
cab5238
to
9c9a09a
Compare
Hello All. Please clarify what command is better to use to build docker image locally, upload to GCP and use ? I do not see useful info in documentation related to docker creation |
@zylon-ai I keep on updating this branch, it would be nice to have a review at some point. Thanks 😉 |
I doubt anyone reads a markdown file within a Docker image
- For documentation purposes - Reflect defaults set in settings-docker.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UID
andGID
build arguments forworker
user. This is useful to not have to change permissions on bind mounted directories.POETRY_EXTRAS
build argument with default values. Useful to re-build the image with some extras using--build-arg POETRY_EXTRAS="..."
Makefile
in Docker image so commands such asmake ingest
can be usedPYTHONPATH
value where path should be/home/worker/app/private_gpt
instead of/private_gpt
/home/worker
when creating user. This resolves a bunch of side dependencies warnings/problems.ENV
instructions together. Just a tiny bit faster to rebuild.PGPT_EMBEDDING_MODE
to define embedding mode. It's not always the same mode as the llm.python3 -m pipx ensurepath
(does not work and is fulfilled byENV PATH="/root/.local/bin:$PATH"
)&&
instead of;
to chain commands to detect failure betterNext PRs (after this one gets merged):
POETRY_EXTRAS
.