fix typo of nvar in smooth.basis1()
#10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. June! This bug must have escaped the attention of ourselves, CRAN, GitHub, and countless users for a very long time. What a relief to have this fixed.
I just installed version 6.1.7 in CRAN four days ago, and I might wait for a week or two to resubmit, but I’m installing 6.1.8 right now.
Jim Ramsay
2748 Howe St.
Ottawa ON K2B 6W9
Tel: (613) 726-1767
Email: ***@***.******@***.***>
On Mar 4, 2024, at 10:45 PM, June Choe ***@***.******@***.***>> wrote:
I encountered a bug due to what I think was a typo in smooth.basis1() where 1:nvar is sometimes 1:var instead. While nvar is defined (and used correctly in other for loops), var is just the function stats::var() - this caused a cryptic error Error in 1:var : NA/NaN argument when the function was called internally via smooth.basis().
Thanks!
…________________________________
You can view, comment on, or merge this pull request online at:
#10
Commit Summary
* 150a6e7<150a6e7> fix nvar typo
File Changes
(1 file<https://github.com/JamesRamsay5/fda/pull/10/files>)
* M R/smooth.basis1.R<https://github.com/JamesRamsay5/fda/pull/10/files#diff-6ef9db84cc296968e82b15ec8ce09fd63a665e5fb967aa3b3ebde2380d802e84> (4)
Patch Links:
* https://github.com/JamesRamsay5/fda/pull/10.patch
* https://github.com/JamesRamsay5/fda/pull/10.diff
—
Reply to this email directly, view it on GitHub<#10>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVB4BQDXH4N4XXSGJBZO6TYWU5W3AVCNFSM6AAAAABEGLVOBCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3DQMRTG43DQOI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Thank you for the quick response! 6.1.8 indeed fixes my code. I'll close this as complete :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a bug due to what I think was a typo in
smooth.basis1()where1:nvaris sometimes1:varinstead. Whilenvaris defined (and used correctly in other for loops),varis just the functionstats::var()- this caused a cryptic errorError in 1:var : NA/NaN argumentwhen the function was called internally viasmooth.basis().Thanks!