[buck2] Add find_missing cache to oss re client #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @miaoyipu! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
JakobDegen
approved these changes
May 15, 2024
|
@JakobDegen the new revision addressed your comments. I don't have the merge permission. If you feels the PR is good to go, could you help me to merge the PR? Thanks |
JakobDegen
reviewed
May 17, 2024
|
@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
May 18, 2024
Summary: We are trying to avoid calling too many ``find_missing`` for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time. X-link: facebook/buck2#644 Reviewed By: samkevich Differential Revision: D57474151 Pulled By: JakobDegen fbshipit-source-id: 2fa28a9ca2c6cfd8a70622483c985793f4f409aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to avoid calling too many
find_missingfor duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time.