Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote execution example for NativeLink #658

Conversation

aleksdmladenovic
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @aleksdmladenovic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@aleksdmladenovic aleksdmladenovic force-pushed the add-remote-execution-nativelink branch from bfef057 to edb3675 Compare May 17, 2024 15:31
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2024
@aleksdmladenovic aleksdmladenovic marked this pull request as ready for review May 19, 2024 01:27
@facebook-github-bot
Copy link
Contributor

@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@JakobDegen
Copy link
Contributor

Very cool, thank you!

@aleksdmladenovic
Copy link
Contributor Author

Could you review this stuff and merge?
Thanks. @JakobDegen .

@MarcusSorealheis
Copy link
Contributor

Super cool. Wow.

@JakobDegen
Copy link
Contributor

@aleksdmladenovic I've imported it into Meta's internal review tool, it's waiting for approval from a second engineer there. I'll be able to merge it once that happens (although note that this PR will be marked as closed, not merged)

@aleksdmladenovic
Copy link
Contributor Author

Thanks. @JakobDegen . I will be waiting for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants