symbolizer: add support for looking up CUs using the .gdb_index if present #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esent This provides similar information as `.debug_aranges` but is better supported on DWARFv4 and with clang. Since it is generated at link time, it has the additional benefit that it is complete, meaning it can return negative results (for symbols such as `_start` that may be implemented in assembly and thus have no associated debug info) without walking the full debuginfo list.
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
How was this tested? Would it be possible to add to the existing test suite? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides similar information as
.debug_arangesbut is better supported on DWARFv4 and with clang. Since it is generated at link time, it has the additional benefit that it is complete, meaning it can return negative results (for symbols such as_startthat may be implemented in assembly and thus have no associated debug info) without walking the full debuginfo list.