Fix C++ Atomic support check #2126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms need libatomic linked for sub-word operations while others need it for super-word operations. Let's make sure we test for all.
|
@luhenry Thank you for addressing this! |
There was a problem hiding this comment.
Maybe also modify a comment at line 184:
# Using clang with libstdc++ requires explicitly linking against libatomic
To something like:
# Using clang with libstdc++ requires explicitly linking against libatomic.
# gcc requires explicit linking against libatomic on some platforms.
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms need libatomic linked for sub-word operations while others need it for super-word operations. Let's make sure we test for all.
Relates to #1907