Fixed playground draggable block while scrolled #5839
Conversation
When using the playground in a smaller window, and scrolling down, it is impossible to move a node to the top node. This fix adjusts the draggableBlockPlugin to allow the placement of a node at the root while scrolled. I encountered this bug in my own build of this plugin.
Legonois
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Legonois! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Hi, could you add a short gif of the issue, I'm trying to reproduce the original problem that's solved. The fix does make sense to me. You would also need to sign the CLA. |
|
Here is the GIF of the issue: I also signed the agreement. Tell me if there's anything else I need to do! |
|
Wait, it still doesn't solve the underlying issue. The target line gets set correctly, but it does not move the block correctly. I will be pushing a change later today |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Hi @Legonois , should we add tests as well for the fix ? |
|
Reopening until the changes from this PR are ported over to the other one. |
When using the playground in a smaller window and scrolling down, it is impossible to move a node to the top node.
This fix adjusts the draggableBlockPlugin to allow the placement of a node at the root while scrolled. It was improperly calculated, as the mouseY variable is tied to the location relative to the page and not the screen.
I encountered this bug in my own build of this plugin.