Fix "TypeError: Cannot use 'in' operator to search for '__language' in null" in LexicalSelection #5912
Conversation
gigantedocil
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
| @@ -1209,7 +1209,7 @@ export class RangeSelection implements BaseSelection { | |||
| const last = nodes[nodes.length - 1]!; | |||
|
|
|||
| // CASE 1: insert inside a code block | |||
| if ('__language' in firstBlock && $isElementNode(firstBlock)) { | |||
| if ($isElementNode(firstBlock) && '__language' in firstBlock) { | |||
There was a problem hiding this comment.
If it is indeed null then the postfix non-null assertion operator is also wrong and should probably be removed so typescript can help sort out some of the other edge cases (if there are any)
-const firstBlock = $getAncestor(firstPoint.getNode(), INTERNAL_$isBlock)!;
+const firstBlock = $getAncestor(firstPoint.getNode(), INTERNAL_$isBlock);There was a problem hiding this comment.
Makes sense, @etrepum . I removed it, but now I'm getting this error on line 1264:
Is it enought to check if firstBlock exists in the if statement on line 1264? Or does this need some other type of logic?
There was a problem hiding this comment.
I am not too familiar with what this code is trying to do and what its expectations are, ignoring the null here would make the type check pass but it might be hiding another bug. @Shubhankerism @zurfyx and @GermanJablo made changes to this function recently and might have a better idea of how to properly fix all of it.
There was a problem hiding this comment.
It would help to know under what circumstance firstBlock is null. In principle it should not happen, since it is a RangeSelection that is not in root (something that is checked at the beginning).
There was a problem hiding this comment.
@GermanJablo, thanks. This is what I was trying to achieve:
There was a problem hiding this comment.
CustomTextNode and CustomParagraph extend the TextNode and ParagraphNode classes, right?
Could you make a repro in codesandbox or stackblitz?
There was a problem hiding this comment.
CustomTextNode and CustomParagraph extend the TextNode and ParagraphNode classes, right?
Yes, exactly.
Could you make a repro in codesandbox or stackblitz?
I'll try to do it during the weekend, whenever I have some free time.
|
are your custom nodes inline or block? |
|
@s0rta, both. I have a CustomParagraphNode that extends ParagraphNode and a CustomTextNode that extends TextNode. |
|
@gigantedocil would you want to throw your nodes into this sandbox? I tried to create a minimum replication and couldn't get it to fail, so there's a different bug somewhere up the call stack for me. But my initial fix was setting the custom node's isInline to true |
|
Thanks, @s0rta. I'll try to do this whenever I have some free time. |
Prevents the error
"TypeError: Cannot use 'in' operator to search for '__language' in null"from being thrown iffirstBlockisnullby putting the$isElementNode(firstBlock)first in the if statement.