fix(LexicalNode): fix inline decorator isSelected #5948
+120
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I pressed
shift + ArrowLeft
at the beginning of the video, and then pressedBackSpace
to delete the selection. You can see the image node is selected, but when I deleted the selection, it didn't been deleted. Actually, the image node was not selected.At the second half of the video, I pressed
shift + ArrowRight
, the first image also showed that it was selected. However, the image node didn't been selected actually, so when I deleted the selection, the image node didn't been deleted.2024-04-24.1.01.56.mov
What
Beside checking whether the selection is collapsed, we should also check non-collapsed situation.
How
First, check whether the node is an inline decorator node.
Then check whether the anchor is before the focus.
Additional Information
After this pr:
2024-04-24.1.20.23.mov