Fix: #5974 Cursor jump to the end of the document when a collaborator deletes focusing paragraph #5975
Conversation
…s-focusing-paragraph
matsuyama-k1
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
@fantactuka could you look into this one, would really like to land this one before the next release. |
packages/lexical-yjs/src/Utils.ts
Outdated
| } | ||
|
|
||
| // retrieve the parent paragraph node for the currently selected node | ||
| const selectedParagraphNode = $findParentParagraphNode( |
There was a problem hiding this comment.
I think you can reuse:
const selectedParagraphNode = $findMatchingParent(selectedNode, (node) => $isParagraphNode(node));
Validate that it's the behaviour you are after - get the closest paragraph parent to 'selectedNode'
|
This is great! Can you pls add a test for this fix? To prevent regression |
packages/lexical-yjs/src/Utils.ts
Outdated
| } | ||
|
|
||
| const prevParagraphNode = $getNodeByKey(prevParagraphNodeKey); | ||
| if (prevParagraphNodeKey in currentParagraphKeys && prevParagraphNode) { |
There was a problem hiding this comment.
As currentParagraphKeys is an array, it should probably be includes() not in
| if (prevParagraphNodeKey in currentParagraphKeys && prevParagraphNode) { | |
| if (currentParagraphKeys .includes(prevParagraphNodeKey) && prevParagraphNode) { |
|
I added a test and fixed! |
|
The pull request that almost same with my code was created and passed....😢 is it ok in Lexilcal community? |
|
A more generic fix was merged here: b5fa87d |
fixed #5974
Screen.Recording.2024-04-27.at.16.41.24.mov