-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework framing for super and __callee__ #7098
Open
headius
wants to merge
7
commits into
jruby:jruby-9.3
Choose a base branch
from
headius:frame_callee_experiment
base: jruby-9.3
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 16, 2022
-
Use static name for super in a module method
Module methods have a dynamic hierarchy, but do not have a dynamic super target name. This eliminates part of the frame requirement for super within a module method, on the way to getting __callee__ working.
Configuration menu - View commit details
-
Copy full SHA for a151aad - Browse repository at this point
Copy the full SHA a151aadView commit details -
Always use ModuleSuper and rewrite define_method
The changes here attempt to get more super calls using a static name, so we can eliminate dependency on a call frame to get that name. * super in a block in any method will start out as a ModuleSuper using the name from the method. * define_method clones and rewrites the block to retarget any super calls to the newly defined name. * all super instructions get rewritten to the appropriate type for the target class, instance/class/module Remaining cases that use UnresolvedSuper may only be the ones where super is invalid, such as a block at top-level or within a class or module body.
Configuration menu - View commit details
-
Copy full SHA for cb27869 - Browse repository at this point
Copy the full SHA cb27869View commit details
Commits on Feb 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 34b33a2 - Browse repository at this point
Copy the full SHA 34b33a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd50860 - Browse repository at this point
Copy the full SHA fd50860View commit details -
Configuration menu - View commit details
-
Copy full SHA for eed5a35 - Browse repository at this point
Copy the full SHA eed5a35View commit details -
Use startup instead of full for super rewriting
startup is simpler time to do this and also the define_method opto will not work if the AST is consumed which is what happens if you full compile.
Configuration menu - View commit details
-
Copy full SHA for 31465a3 - Browse repository at this point
Copy the full SHA 31465a3View commit details
Commits on Feb 23, 2022
-
Additional tweaks for define_methods super
* Alter scope class to be the target class, so it will be used as the base class when doing InstanceSuper. This fixes the last remaining failure in specs. * Also consider and rewrite super in nested closures. This fixes the last remaining failure in CRuby tests.
Configuration menu - View commit details
-
Copy full SHA for 7e71845 - Browse repository at this point
Copy the full SHA 7e71845View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.